Sign upLogin

rubysg/rubysg-reboot

View on GitHub
Star

Showing 3 of 13 total issues

Method perform has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform(id)
    sub = RubySgBotSubscriber.find_by!(chat_id: id.to_s)
    featured_articles = RubyWeekly.new.featured_articles

    send_telegram_message(
Severity: Minor
Found in app/jobs/send_weekly_updates_job.rb - About 1 hr to fix

    Method questions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def questions(qns = [])
      qns.each do |qn|
        raise(WrongQuestionFormatError, "Question must contain key") unless qn.include?(:key)
        raise(WrongQuestionFormatError, "Question must contain question") unless qn.include?(:question)
    Severity: Minor
    Found in app/forms/feedback_form.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method featured_articles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def featured_articles
    doc = Nokogiri::HTML(latest_feed["description"])
    contents = doc.search('/html/body/table/tr/td/div/table')

    jobs_section_index = 0
    Severity: Minor
    Found in app/services/ruby_weekly.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language