rwbutler/Hash

View on GitHub

Showing 5 of 17 total issues

Function data has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    func data(operation: CCOperation) -> Data {
        var outLength = Int(0)
        let inputData = message
        let length = (algorithm.blockSize() + inputData.count)
        var outputData = Data(count: length)
Severity: Minor
Found in Hash/Classes/Cryptography/Cryptable.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function data has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func data(operation: CCOperation) -> Data {
        var outLength = Int(0)
        let inputData = message
        let length = (algorithm.blockSize() + inputData.count)
        var outputData = Data(count: length)
Severity: Minor
Found in Hash/Classes/Cryptography/Cryptable.swift - About 1 hr to fix

    Function data has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public func data() -> Data {
            let data = message
            let length = algorithm.digestLength()
            var digestData = Data(count: length)
            _ = digestData.withUnsafeMutableBytes { digestBytes -> UInt8 in
    Severity: Minor
    Found in Hash/Classes/Message Digest/Hash.swift - About 1 hr to fix

      Function data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public func data() -> Data {
              let data = message
              let length = hashAlgorithm.digestLength()
              var digestData = Data(count: length)
              _ = digestData.withUnsafeMutableBytes { digestBytes -> UInt8 in
      Severity: Minor
      Found in Hash/Classes/Message Authentication Codes/HMAC.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public func data() -> Data {
              let data = message
              let length = algorithm.digestLength()
              var digestData = Data(count: length)
              _ = digestData.withUnsafeMutableBytes { digestBytes -> UInt8 in
      Severity: Minor
      Found in Hash/Classes/Message Digest/Hash.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language