Sign upLogin

rx/presenters

View on GitHub
Star
views/mdc/assets/js/components/events/toggle_visibility.js

Summary

Maintainability
D
1 day
Test Coverage

Function call has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    call(results) {
        const targetId = this.targetId;
        const action = this.params.action;
        const delayAmt = this.event instanceof FocusEvent ? 500 : 0;
        const elem = this.root.getElementById(targetId);
Severity: Minor
Found in views/mdc/assets/js/components/events/toggle_visibility.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function call has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    call(results) {
        const targetId = this.targetId;
        const action = this.params.action;
        const delayAmt = this.event instanceof FocusEvent ? 500 : 0;
        const elem = this.root.getElementById(targetId);
Severity: Major
Found in views/mdc/assets/js/components/events/toggle_visibility.js - About 2 hrs to fix

    Function promiseObj has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            const promiseObj = new Promise(function(resolve) {
            clearTimeout(elem.vTimeout);
            elem.vTimeout = setTimeout(function() {
                console.debug('Toggling visibility on: ' + targetId);
    Severity: Minor
    Found in views/mdc/assets/js/components/events/toggle_visibility.js - About 1 hr to fix

      Function vTimeout has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  elem.vTimeout = setTimeout(function() {
                console.debug('Toggling visibility on: ' + targetId);

                if (action === 'show') {
                    if (elem.vComponent && elem.vComponent.show) {
      Severity: Minor
      Found in views/mdc/assets/js/components/events/toggle_visibility.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!elem) {
            const err = new Error(
                `Unable to locate node ${targetId}!`
                + ' Did you forget to attach it?',
            );
        Severity: Major
        Found in views/mdc/assets/js/components/events/toggle_visibility.js and 1 other location - About 2 hrs to fix
        views/mdc/assets/js/components/events/toggle_disabled.js on lines 15..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            constructor(options, params, event, root) {
        this.targetId = options.target;
        this.params = params;
        this.event = event;
        this.root = root;
        Severity: Major
        Found in views/mdc/assets/js/components/events/toggle_visibility.js and 2 other locations - About 1 hr to fix
        views/mdc/assets/js/components/events/dialog.js on lines 2..7
        views/mdc/assets/js/components/events/toggle_disabled.js on lines 2..7

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        else if (action === 'hide') {
                    if (elem.vComponent && elem.vComponent.hide) {
                        elem.vComponent.hide();
                    }
                    else {
        Severity: Major
        Found in views/mdc/assets/js/components/events/toggle_visibility.js and 1 other location - About 1 hr to fix
        views/mdc/assets/js/components/events/toggle_visibility.js on lines 35..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (action === 'show') {
                    if (elem.vComponent && elem.vComponent.show) {
                        elem.vComponent.show();
                    }
                    else {
        Severity: Major
        Found in views/mdc/assets/js/components/events/toggle_visibility.js and 1 other location - About 1 hr to fix
        views/mdc/assets/js/components/events/toggle_visibility.js on lines 43..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status