Sign upLogin

ryanto/acts_as_votable

View on GitHub
Star

Showing 6 of 10 total issues

Method update_cached_votes has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def update_cached_votes(vote_scope = nil)
      updates = {}

      if self.respond_to?(:cached_votes_up=)
        updates[:cached_votes_up] = count_votes_up(true)
Severity: Minor
Found in lib/acts_as_votable/cacheable.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_cached_votes has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def update_cached_votes(vote_scope = nil)
      updates = {}

      if self.respond_to?(:cached_votes_up=)
        updates[:cached_votes_up] = count_votes_up(true)
Severity: Major
Found in lib/acts_as_votable/cacheable.rb - About 2 hrs to fix

    Method vote_by has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def vote_by(args = {})
      return false if args[:voter].nil?

      options = { vote: true, vote_scope: nil }.merge(args)
    Severity: Minor
    Found in lib/acts_as_votable/votable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method scope_cache_field has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def scope_cache_field(field, vote_scope)
      return field if vote_scope.nil?

      case field
      when :cached_votes_total=
    Severity: Minor
    Found in lib/acts_as_votable/cacheable.rb - About 1 hr to fix

      Method included has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.included(base)
      # allow the user to define these himself
      aliases = {

        vote_up: [
      Severity: Minor
      Found in lib/acts_as_votable/votable.rb - About 1 hr to fix

        Method vote_by has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def vote_by(args = {})
      return false if args[:voter].nil?

      options = { vote: true, vote_scope: nil }.merge(args)
        Severity: Minor
        Found in lib/acts_as_votable/votable.rb - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language