ryanuber/oaf

View on GitHub

Showing 3 of 3 total issues

Method parse_http_meta has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_http_meta text
    headers = {}
    status = 200
    size = 0
    parts = text.split /^---$/
Severity: Minor
Found in lib/oaf/util.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method flatten has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def flatten data
    result = ''
    if data.kind_of? Hash
      data.each do |key, val|
        val = Oaf::Util.flatten val if not val.kind_of? String
Severity: Minor
Found in lib/oaf/util.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_output has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def get_output file, req_path=nil, headers=[], body=[], params=[]
Severity: Minor
Found in lib/oaf/util.rb - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language