ryz310/my_api_client

View on GitHub

Showing 5 of 5 total issues

Method _request_with_relative_uri has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _request_with_relative_uri(http_method, pathname, headers, query, body)
Severity: Minor
Found in lib/my_api_client/request.rb - About 35 mins to fix

    Method match_body? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def match_body?(json, response_body)
            return true if json.nil?
            return response_body.nil? if json == :forbid_nil
            return false if response_body.blank?
    
    
    Severity: Minor
    Found in lib/my_api_client/error_handling/generator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process_raise_option has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def process_raise_option(exception, response, status_code)
          case exception
          when Class
            params = MyApiClient::Params::Params.new(nil, stub_as_response(response, status_code))
            if exception == MyApiClient::NetworkError
    Severity: Minor
    Found in lib/my_api_client/rspec/stub.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def call
            return unless match?(_status_code, _response.status)
            return unless match_headers?(_headers, _response.headers)
            return unless match_body?(_json, _response.body)
    
    
    Severity: Minor
    Found in lib/my_api_client/error_handling/generator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate_stubbed_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def generate_stubbed_response(options, *request) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
          case options
          when Proc
            stub_as_resource(options.call(*request))
          when Hash
    Severity: Minor
    Found in lib/my_api_client/rspec/stub.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language