Sign upLogin

saasbook/esaas-engagements

View on GitHub
Star

Showing 25 of 71 total issues

File matching_controller.rb has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MatchingController < ApplicationController
  # redirects students to their engagement's preference page
  # only if they are involved in a matching in progress
  skip_before_filter :check_student
  before_action :auth_matching, except: [:show, :store]
Severity: Minor
Found in app/controllers/matching_controller.rb - About 2 hrs to fix

    Method index has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def index
    deploy_vet_map
    total_app = @total_deploy + @total_vet
    @current_user = User.find_by_id(session[:user_id])
    page_default_and_update("app", total_app)
    Severity: Minor
    Found in app/controllers/apps_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def index
        user = current_user
        orgs = Org.for_user(user.id)
        deploy_vet_map(orgs)
        total_app = @total_deploy + @total_vet
    Severity: Minor
    Found in app/controllers/my_projects_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def index
        user = current_user
        orgs = Org.for_user(user.id)
        deploy_vet_map(orgs)
        total_app = @total_deploy + @total_vet
    Severity: Major
    Found in app/controllers/my_projects_controller.rb - About 2 hrs to fix

      Method index has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def index
    deploy_vet_map
    total_app = @total_deploy + @total_vet
    @current_user = User.find_by_id(session[:user_id])
    page_default_and_update("app", total_app)
      Severity: Major
      Found in app/controllers/apps_controller.rb - About 2 hrs to fix

        Method update_engagement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def update_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
        Severity: Minor
        Found in app/controllers/matching_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create
    # check if student is already in an existing engagement
    # check if team_number is unique
    seen = []
    team_numbers = []
        Severity: Minor
        Found in app/controllers/matching_controller.rb - About 1 hr to fix

          Method propose has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def propose(team, team_preferences)
      team_preferences.each do |app|
        puts "Team preferences: " + team_preferences.to_s
        puts "Team " + team + " proposing to App " + app
        # Check if the app is currently matched
          Severity: Minor
          Found in app/models/matching.rb - About 1 hr to fix

            Method create_engagement has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def create_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
            Severity: Minor
            Found in app/controllers/matching_controller.rb - About 1 hr to fix

              Method update_engagement has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def update_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
              Severity: Minor
              Found in app/controllers/matching_controller.rb - About 1 hr to fix

                Method results has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                  def results
    keyword = params["keyword"]
    @filters = session[:filters]
    @apps = []
    @orgs = []
                Severity: Minor
                Found in app/controllers/search_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                  def create
    # check if student is already in an existing engagement
    # check if team_number is unique
    seen = []
    team_numbers = []
                Severity: Minor
                Found in app/controllers/matching_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method results has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def results
    keyword = params["keyword"]
    @filters = session[:filters]
    @apps = []
    @orgs = []
                Severity: Minor
                Found in app/controllers/search_controller.rb - About 1 hr to fix

                  Method auth_matching has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def auth_matching
    @@name_path = request.env['PATH_INFO']
    if current_user&.client?
      begin
        redirect_to :back, alert: "You do not have access to that page."
                  Severity: Minor
                  Found in app/controllers/application_controller.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method create_engagement has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def create_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
                  Severity: Minor
                  Found in app/controllers/matching_controller.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method store has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def store
    @matching = Matching.find(params[:matching_id])
    @engagement = Engagement.find(params[:engagement_id])

    # Update last update users
                  Severity: Minor
                  Found in app/controllers/matching_controller.rb - About 1 hr to fix

                    Method update_edit_request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def update_edit_request
      # Todo: send email. Right now the client never see's feedback if the edits are approved.
      @app_edit_request.approver = current_user
      if params[:approve]
        @app.description = (@app_edit_request.description.blank?) ? @app.features : @app_edit_request.description
                    Severity: Minor
                    Found in app/controllers/my_approval_requests_controller.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def update
        redirect_to new_my_project_edit_path and return if @app_edit_request.nil?
        unless update_to_edit_made(@app_edit_request)
            redirect_to edit_my_project_edit_path, alert: 'There were no updates to edits made.'
            return
                    Severity: Minor
                    Found in app/controllers/my_projects_controller.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def create
        redirect_to edit_my_project_edit_path(app_id: params[:app_id]) and return unless @app_edit_request.nil?
        @app_edit_request = AppEditRequest.new(
            app_id:       params[:app_id],
            description:  params[:description],
                    Severity: Minor
                    Found in app/controllers/my_projects_controller.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method mail_to has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      def mail_to(name, email, subject, content, sender)
                    Severity: Minor
                    Found in app/mailers/form_mailer.rb - About 35 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language