Sign upLogin

salsify/delayed_job_worker_pool

View on GitHub
Star

Showing 2 of 2 total issues

Class WorkerPool has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class WorkerPool

    SIGNALS = ['TERM', 'INT'].map(&:freeze).freeze
    DEFAULT_WORKER_COUNT = 1
Severity: Minor
Found in lib/delayed_job_worker_pool/worker_pool.rb - About 2 hrs to fix

    Method log_uninheritable_threads has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def log_uninheritable_threads
      Thread.list.each do |t|
        next if t == Thread.current

        if t.respond_to?(:backtrace)
    Severity: Minor
    Found in lib/delayed_job_worker_pool/worker_pool.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language