Sign upLogin

saltstack/salt

View on GitHub
Star

Showing 9,953 of 17,590 total issues

File boto_ec2.py has 1538 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Manage EC2

.. versionadded:: 2015.8.0
Severity: Major
Found in salt/states/boto_ec2.py - About 4 days to fix

    File win_iis.py has 1532 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
'''
Microsoft IIS site management via WebAdministration powershell module

:maintainer:    Shane Lee <slee@saltstack.com>, Robert Booth <rbooth@saltstack.com>
    Severity: Major
    Found in salt/modules/win_iis.py - About 4 days to fix

      Function check_requisite has a Cognitive Complexity of 200 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_requisite(self, low, running, chunks, pre=False):
        '''
        Look into the running data to check the status of all requisite
        states
        '''
      Severity: Minor
      Found in salt/state.py - About 4 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File bootstrap.js has 1508 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* ===================================================
 * bootstrap-transition.js v2.3.0
 * http://twitter.github.com/bootstrap/javascript.html#transitions
 * ===================================================
 * Copyright 2012 Twitter, Inc.
      Severity: Major
      Found in doc/_themes/saltstack/static/js/vendor/bootstrap.js - About 4 days to fix

        Function running has a Cognitive Complexity of 196 (exceeds 5 allowed). Consider refactoring.
        Open

        def running(name,
            image=None,
            skip_translate=None,
            ignore_collisions=False,
            validate_ip_addrs=True,
        Severity: Minor
        Found in salt/states/docker_container.py - About 4 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function present has a Cognitive Complexity of 194 (exceeds 5 allowed). Consider refactoring.
        Open

        def present(name, mediatype, **kwargs):
    '''
    Creates new mediatype.
    NOTE: This function accepts all standard mediatype properties: keyword argument names differ depending on your
    zabbix version, see:
        Severity: Minor
        Found in salt/states/zabbix_mediatype.py - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File boto_iam.py has 1489 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
'''
Manage IAM objects
==================
        Severity: Major
        Found in salt/states/boto_iam.py - About 3 days to fix

          Cyclomatic complexity is too high in function extracted. (199)
          Open

          def extracted(name,
              source,
              source_hash=None,
              source_hash_name=None,
              source_hash_update=False,
          Severity: Minor
          Found in salt/states/archive.py by radon

          Cyclomatic Complexity

          Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

          Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

          Construct Effect on CC Reasoning
          if +1 An if statement is a single decision.
          elif +1 The elif statement adds another decision.
          else +0 The else statement does not cause a new decision. The decision is at the if.
          for +1 There is a decision at the start of the loop.
          while +1 There is a decision at the while statement.
          except +1 Each except branch adds a new conditional path of execution.
          finally +0 The finally block is unconditionally executed.
          with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
          assert +1 The assert statement internally roughly equals a conditional statement.
          Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
          Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

          Source: http://radon.readthedocs.org/en/latest/intro.html

          File boto_vpc.py has 1468 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
'''
Manage VPCs
=================
          Severity: Major
          Found in salt/states/boto_vpc.py - About 3 days to fix

            File panos.py has 1467 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
'''
Module to provide Palo Alto compatibility to Salt

:codeauthor: ``Spencer Ervin <spencer_ervin@hotmail.com>``
            Severity: Major
            Found in salt/modules/panos.py - About 3 days to fix

              File github.py has 1466 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
'''
Module for interacting with the GitHub v3 API.

.. versionadded:: 2016.3.0
              Severity: Major
              Found in salt/modules/github.py - About 3 days to fix

                File network.py has 1463 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # -*- coding: utf-8 -*-
'''
Module for gathering and managing network information
'''
                Severity: Major
                Found in salt/modules/network.py - About 3 days to fix

                  Function directory has a Cognitive Complexity of 188 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def directory(name,
              user=None,
              group=None,
              recurse=None,
              max_depth=None,
                  Severity: Minor
                  Found in salt/states/file.py - About 3 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File mount.py has 1441 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
'''
Salt module to manage Unix mounts and the fstab file
'''
                  Severity: Major
                  Found in salt/modules/mount.py - About 3 days to fix

                    File napalm_mod.py has 1436 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # -*- coding: utf-8 -*-
'''
NAPALM helpers
==============
                    Severity: Major
                    Found in salt/modules/napalm_mod.py - About 3 days to fix

                      File x509.py has 1411 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # -*- coding: utf-8 -*-
'''
Manage X509 certificates

.. versionadded:: 2015.8.0
                      Severity: Major
                      Found in salt/modules/x509.py - About 3 days to fix

                        File __init__.py has 1410 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        # -*- coding: utf-8 -*-
'''
Create ssh executor system
'''
# Import python libs
                        Severity: Major
                        Found in salt/client/ssh/__init__.py - About 3 days to fix

                          Function create has a Cognitive Complexity of 180 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def create(vm_):
    '''
    To create a single VM in the VMware environment.

    Sample profile and arguments that can be specified in it can be found
                          Severity: Minor
                          Found in salt/cloud/clouds/vmware.py - About 3 days to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          File schedule.py has 1384 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          # -*- coding: utf-8 -*-

# See doc/topics/jobs/index.rst
'''
Scheduling routines are located here. To activate the scheduler make the
                          Severity: Major
                          Found in salt/utils/schedule.py - About 3 days to fix

                            Function managed has a Cognitive Complexity of 178 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def managed(name,
            source=None,
            source_hash='',
            source_hash_name=None,
            keep_source=True,
                            Severity: Minor
                            Found in salt/states/file.py - About 3 days to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language