Sign upLogin

saltstack/salt

View on GitHub
Star

Showing 9,953 of 17,590 total issues

File win_file.py has 1240 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Manage information about files on the minion, set/read user, group
data, modify the ACL of files/directories
Severity: Major
Found in salt/modules/win_file.py - About 3 days to fix

    File iptables.py has 1234 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
'''
Support for iptables

Configuration Options
    Severity: Major
    Found in salt/modules/iptables.py - About 3 days to fix

      File schema.py has 1233 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # -*- coding: utf-8 -*-
'''
    :codeauthor: Pedro Algarvio (pedro@algarvio.me)
    :codeauthor: Alexandru Bleotu (alexandru.bleotu@morganstanley.com)
      Severity: Major
      Found in salt/utils/schema.py - About 3 days to fix

        Function create has a Cognitive Complexity of 155 (exceeds 5 allowed). Consider refactoring.
        Open

        def create(vm_):
    '''
    Create a single VM from a data dict

    CLI Example:
        Severity: Minor
        Found in salt/cloud/clouds/proxmox.py - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function verify_high has a Cognitive Complexity of 155 (exceeds 5 allowed). Consider refactoring.
        Open

            def verify_high(self, high):
        '''
        Verify that the high data is viable and follows the data structure
        '''
        errors = []
        Severity: Minor
        Found in salt/state.py - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function call_chunk has a Cognitive Complexity of 155 (exceeds 5 allowed). Consider refactoring.
        Open

            def call_chunk(self, low, running, chunks):
        '''
        Check if a chunk has any requires, execute the requires and then
        the chunk
        '''
        Severity: Minor
        Found in salt/state.py - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File masterapi.py has 1214 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
'''
This module contains all of the routines needed to set up a master server, this
involves preparing the three listeners and the workers needed by the master.
'''
        Severity: Major
        Found in salt/daemons/masterapi.py - About 3 days to fix

          File boto_apigateway.py has 1208 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
'''
Connection module for Amazon APIGateway

.. versionadded:: 2016.11.0
          Severity: Major
          Found in salt/modules/boto_apigateway.py - About 3 days to fix

            File tcp.py has 1199 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
'''
TCP transport classes

Wire protocol: "len(payload) msgpack({'head': SOMEHEADER, 'body': SOMEBODY})"
            Severity: Major
            Found in salt/transport/tcp.py - About 3 days to fix

              Cyclomatic complexity is too high in function installed. (158)
              Open

              def installed(
        name,
        version=None,
        refresh=None,
        fromrepo=None,
              Severity: Minor
              Found in salt/states/pkg.py by radon

              Cyclomatic Complexity

              Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

              Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

              Construct Effect on CC Reasoning
              if +1 An if statement is a single decision.
              elif +1 The elif statement adds another decision.
              else +0 The else statement does not cause a new decision. The decision is at the if.
              for +1 There is a decision at the start of the loop.
              while +1 There is a decision at the while statement.
              except +1 Each except branch adds a new conditional path of execution.
              finally +0 The finally block is unconditionally executed.
              with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
              assert +1 The assert statement internally roughly equals a conditional statement.
              Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
              Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

              Source: http://radon.readthedocs.org/en/latest/intro.html

              Function symlink has a Cognitive Complexity of 151 (exceeds 5 allowed). Consider refactoring.
              Open

              def symlink(
        name,
        target,
        force=False,
        backupname=None,
              Severity: Minor
              Found in salt/states/file.py - About 3 days to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function present has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.
              Open

              def present(name,
            skip_translate=None,
            ignore_collisions=False,
            validate_ip_addrs=True,
            containers=None,
              Severity: Minor
              Found in salt/states/docker_network.py - About 3 days to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File pip.py has 1178 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
r'''
Install Python packages with pip to either the system or a virtualenv

Windows Support
              Severity: Major
              Found in salt/modules/pip.py - About 3 days to fix

                Function installed has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
                Open

                def installed(name,
              pkgs=None,
              pip_bin=None,
              requirements=None,
              bin_env=None,
                Severity: Minor
                Found in salt/states/pip_state.py - About 3 days to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _hw_data has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
                Open

                def _hw_data(osdata):
    '''
    Get system specific hardware data from dmidecode

    Provides
                Severity: Minor
                Found in salt/grains/core.py - About 3 days to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _format_host has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
                Open

                def _format_host(host, data, indent_level=1):
    '''
    Main highstate formatter. can be called recursively if a nested highstate
    contains other highstates (ie in an orchestration)
    '''
                Severity: Minor
                Found in salt/output/highstate.py - About 3 days to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File panos.py has 1176 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # -*- coding: utf-8 -*-
'''
A state module to manage Palo Alto network devices.

:codeauthor: ``Spencer Ervin <spencer_ervin@hotmail.com>``
                Severity: Major
                Found in salt/states/panos.py - About 3 days to fix

                  File boto_elb.py has 1174 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
'''
Manage ELBs

.. versionadded:: 2014.7.0
                  Severity: Major
                  Found in salt/states/boto_elb.py - About 3 days to fix

                    File junos.py has 1174 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # -*- coding: utf-8 -*-
'''
Module to interact with Junos devices.

:maturity: new
                    Severity: Major
                    Found in salt/modules/junos.py - About 3 days to fix

                      Function run has a Cognitive Complexity of 148 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def run(self):
        '''
        Execute the batch run
        '''
        args = [[],
                      Severity: Minor
                      Found in salt/cli/batch.py - About 3 days to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language