Sign upLogin

saltstack/salt

View on GitHub
Star

Showing 9,400 of 17,590 total issues

File schema.py has 1233 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
    :codeauthor: Pedro Algarvio (pedro@algarvio.me)
    :codeauthor: Alexandru Bleotu (alexandru.bleotu@morganstanley.com)
Severity: Major
Found in salt/utils/schema.py - About 3 days to fix

    Function create has a Cognitive Complexity of 155 (exceeds 5 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single VM from a data dict

    CLI Example:
    Severity: Minor
    Found in salt/cloud/clouds/proxmox.py - About 3 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function verify_high has a Cognitive Complexity of 155 (exceeds 5 allowed). Consider refactoring.
    Open

        def verify_high(self, high):
        '''
        Verify that the high data is viable and follows the data structure
        '''
        errors = []
    Severity: Minor
    Found in salt/state.py - About 3 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function call_chunk has a Cognitive Complexity of 155 (exceeds 5 allowed). Consider refactoring.
    Open

        def call_chunk(self, low, running, chunks):
        '''
        Check if a chunk has any requires, execute the requires and then
        the chunk
        '''
    Severity: Minor
    Found in salt/state.py - About 3 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File masterapi.py has 1214 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
'''
This module contains all of the routines needed to set up a master server, this
involves preparing the three listeners and the workers needed by the master.
'''
    Severity: Major
    Found in salt/daemons/masterapi.py - About 3 days to fix

      File boto_apigateway.py has 1208 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # -*- coding: utf-8 -*-
'''
Connection module for Amazon APIGateway

.. versionadded:: 2016.11.0
      Severity: Major
      Found in salt/modules/boto_apigateway.py - About 3 days to fix

        File tcp.py has 1199 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
'''
TCP transport classes

Wire protocol: "len(payload) msgpack({'head': SOMEHEADER, 'body': SOMEBODY})"
        Severity: Major
        Found in salt/transport/tcp.py - About 3 days to fix

          Function symlink has a Cognitive Complexity of 151 (exceeds 5 allowed). Consider refactoring.
          Open

          def symlink(
        name,
        target,
        force=False,
        backupname=None,
          Severity: Minor
          Found in salt/states/file.py - About 3 days to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function present has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.
          Open

          def present(name,
            skip_translate=None,
            ignore_collisions=False,
            validate_ip_addrs=True,
            containers=None,
          Severity: Minor
          Found in salt/states/docker_network.py - About 3 days to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File pip.py has 1178 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
r'''
Install Python packages with pip to either the system or a virtualenv

Windows Support
          Severity: Major
          Found in salt/modules/pip.py - About 3 days to fix

            Function installed has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
            Open

            def installed(name,
              pkgs=None,
              pip_bin=None,
              requirements=None,
              bin_env=None,
            Severity: Minor
            Found in salt/states/pip_state.py - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _hw_data has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
            Open

            def _hw_data(osdata):
    '''
    Get system specific hardware data from dmidecode

    Provides
            Severity: Minor
            Found in salt/grains/core.py - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _format_host has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
            Open

            def _format_host(host, data, indent_level=1):
    '''
    Main highstate formatter. can be called recursively if a nested highstate
    contains other highstates (ie in an orchestration)
    '''
            Severity: Minor
            Found in salt/output/highstate.py - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File panos.py has 1176 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
'''
A state module to manage Palo Alto network devices.

:codeauthor: ``Spencer Ervin <spencer_ervin@hotmail.com>``
            Severity: Major
            Found in salt/states/panos.py - About 3 days to fix

              File boto_elb.py has 1174 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
'''
Manage ELBs

.. versionadded:: 2014.7.0
              Severity: Major
              Found in salt/states/boto_elb.py - About 3 days to fix

                File junos.py has 1174 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # -*- coding: utf-8 -*-
'''
Module to interact with Junos devices.

:maturity: new
                Severity: Major
                Found in salt/modules/junos.py - About 3 days to fix

                  Function run has a Cognitive Complexity of 148 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def run(self):
        '''
        Execute the batch run
        '''
        args = [[],
                  Severity: Minor
                  Found in salt/cli/batch.py - About 3 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File neutron.py has 1168 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
'''
Module for handling OpenStack Neutron calls

:depends:   - neutronclient Python module
                  Severity: Major
                  Found in salt/modules/neutron.py - About 3 days to fix

                    File event.py has 1167 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # -*- coding: utf-8 -*-
'''
Manage events

Events are all fired off via a zeromq 'pub' socket, and listened to with local
                    Severity: Major
                    Found in salt/utils/event.py - About 3 days to fix

                      File dracr.py has 1166 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # -*- coding: utf-8 -*-
'''
Manage Dell DRAC

.. versionadded:: 2015.8.2
                      Severity: Major
                      Found in salt/modules/dracr.py - About 3 days to fix
                        Severity
                        Category
                        Status
                        Source
                        Language