Sign upLogin

saltstack/salt

View on GitHub
Star

Showing 9,400 of 17,590 total issues

Avoid deeply nested control flow statements.
Open

                    if _dict_match(member,
                                   matchstr,
                                   regex_match=regex_match,
                                   exact_match=exact_match):
                        return True
Severity: Major
Found in salt/utils/data.py - About 45 mins to fix

    Function finger_all has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def finger_all(self, hash_type=None):
        '''
        Return fingerprints for all keys
        '''
        if hash_type is None:
    Severity: Minor
    Found in salt/key.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function is_smartos_zone has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def is_smartos_zone():
    '''
    Function to return if host is SmartOS (Illumos) and not the gz
    '''
    if not is_smartos():
    Severity: Minor
    Found in salt/utils/platform.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function memoize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def memoize(func):
    '''
    Memoize aka cache the return output of a function
    given a specific set of arguments
    Severity: Minor
    Found in salt/utils/decorators/__init__.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if fnmatch.fnmatch(key, match_item):
                            if status not in ret:
                                ret[status] = []
                            ret[status].append(key)
                else:
    Severity: Major
    Found in salt/key.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if status not in ret:
                            ret[status] = []
                        ret[status].append(key)
      Severity: Major
      Found in salt/key.py - About 45 mins to fix

        Function finger has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def finger(self, match, hash_type=None):
        '''
        Return the fingerprint for a specified key
        '''
        if hash_type is None:
        Severity: Minor
        Found in salt/key.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function format_logstash_v0 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def format_logstash_v0(self, record):
        '''
        Messages are formatted in logstash's expected format.
        '''
        host = salt.utils.network.get_fqhostname()
        Severity: Minor
        Found in salt/log/handlers/fluent_mod.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function format_v1 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def format_v1(self, record):
        message_dict = {
            '@version': 1,
            '@timestamp': self.formatTime(record),
            'host': salt.utils.network.get_fqhostname(),
        Severity: Minor
        Found in salt/log/handlers/logstash_mod.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if _match(item,
                                  pattern,
                                  regex_match=regex_match,
                                  exact_match=exact_match):
                            return True
        Severity: Major
        Found in salt/utils/data.py - About 45 mins to fix

          Function is_smartos_globalzone has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def is_smartos_globalzone():
    '''
    Function to return if host is SmartOS (Illumos) global zone or not
    '''
    if not is_smartos():
          Severity: Minor
          Found in salt/utils/platform.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _flatten has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def _flatten(self, data, path=''):
        if not data:
            return {path: {}}
        path = path.strip('/')
        flat = {}
          Severity: Minor
          Found in salt/utils/etcd_util.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function has_permission has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def has_permission(obj_name,
                   principal,
                   permission,
                   access_mode='grant',
                   obj_type='file',
          Severity: Minor
          Found in salt/utils/win_dacl.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_conn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def get_conn(opts, profile=None, host=None, port=None):
    '''
    Return a conn object for accessing memcached
    '''
    if not (host and port):
          Severity: Minor
          Found in salt/utils/memcached.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _run_all has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def _run_all(cmd):
    '''

    Args:
        cmd:
          Severity: Minor
          Found in salt/utils/mac_utils.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ensure_dict_key has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def ensure_dict_key(
        in_dict,
        keys,
        delimiter=DEFAULT_TARGET_DELIM,
        ordered_dict=False):
          Severity: Minor
          Found in salt/utils/dictupdate.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                              if not applies_to:
                        if obj_type.lower() in ['registry', 'registry32']:
                            applies_to = 'this_key_subkeys'
                        else:
                            applies_to = 'this_folder_subfolders_files'
          Severity: Major
          Found in salt/utils/win_dacl.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if not has_permission(obj_name=obj_name,
                                          principal=user_name,
                                          permission=perm,
                                          access_mode=access_mode,
                                          obj_type=obj_type,
            Severity: Major
            Found in salt/utils/win_dacl.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if __opts__['test'] is True:
                        if 'remove_perms' not in ret['changes']:
                            ret['changes']['remove_perms'] = {}
                        ret['changes']['remove_perms'].update(
                            {user_name: cur_perms['Not Inherited'][user_name]})
              Severity: Major
              Found in salt/utils/win_dacl.py - About 45 mins to fix

                Function wait_for_psexecsvc has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                def wait_for_psexecsvc(host, port, username, password, timeout=900):
    '''
    Wait until psexec connection can be established.
    '''
    if has_winexe() and not HAS_PSEXEC:
                Severity: Minor
                Found in salt/utils/cloud.py - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language