saltstack/salt

View on GitHub

Showing 9,400 of 17,590 total issues

Avoid deeply nested control flow statements.
Open

                    if salt.utils.platform.is_windows():
                        fp_.close()
                    # Maybe the file is already gone
                    try:
Severity: Major
Found in salt/utils/schedule.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        for name in dirs:
                            path = os.path.join(root, name)
                            fmode = os.stat(path)
                            if fmode.st_uid != uid or fmode.st_gid != gid:
                                if permissive and fmode.st_gid in groups:
    Severity: Major
    Found in salt/utils/verify.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if make_syndic is True:
                              deploy_command += ' -S'
                          if make_master is True:
      Severity: Major
      Found in salt/utils/cloud.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if preseed_minion_keys is not None:
                                deploy_command += ' -k \'{0}\''.format(
                                    preseed_minion_keys_tempdir
                                )
                        if script_args:
        Severity: Major
        Found in salt/utils/cloud.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if script_env:
                                  root_cmd(
                                      'rm -f \'{0}/environ-deploy-wrapper.sh\''.format(
                                          tmp_dir
                                      ),
          Severity: Major
          Found in salt/utils/cloud.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                for k, v in six.iteritems(d0):
                                    r_set[k] = v
                    status = _unwrap_dict(r_set, argument_being_watched)
            Severity: Major
            Found in salt/utils/cloud.py - About 45 mins to fix

              Function check_max_open_files has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def check_max_open_files(opts):
                  '''
                  Check the number of max allowed open files and adjust if needed
                  '''
                  mof_c = opts.get('max_open_files', 100000)
              Severity: Minor
              Found in salt/utils/verify.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                  for name in files:
                                      if name.startswith('.'):
                                          continue
                                      path = os.path.join(root, name)
                                      try:
              Severity: Major
              Found in salt/utils/verify.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if item.startswith('_'):
                                            del schedule[job][item]
                        return schedule
                Severity: Major
                Found in salt/utils/schedule.py - About 45 mins to fix

                  Function render_reaction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def render_reaction(self, glob_ref, tag, data):
                          '''
                          Execute the render system against a single reaction file and return
                          the data structure
                          '''
                  Severity: Minor
                  Found in salt/utils/reactor.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                      if 'secondary' not in cols:
                                          ipaddr, netmask, broadcast, scope = parse_network(value, cols)
                                          if type_ == 'inet':
                                              if 'inet' not in data:
                                                  data['inet'] = list()
                  Severity: Major
                  Found in salt/utils/network.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if iret[sl]['state'] == 1:  # 1 is ESTABLISHED
                                            del iret[sl]['state']
                                            ret[len(ret)] = iret[sl]
                        return ret
                    Severity: Major
                    Found in salt/utils/network.py - About 45 mins to fix

                      Function _sunos_remotes_on has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def _sunos_remotes_on(port, which_end):
                          '''
                          SunOS specific helper function.
                          Returns set of ipv4 host addresses of remote established connections
                          on local or remote tcp port.
                      Severity: Minor
                      Found in salt/utils/network.py - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                                              if hst[0][:4] in ('127.', '::1') or len(hst) == 1:
                                                  hosts.extend(hst)
                              except IOError:
                      Severity: Major
                      Found in salt/utils/network.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (len(load['retcode']) > fun_index and
                                                        load['retcode'][fun_index] and
                                                        fun in SUB_EVENT):
                                                    # Minion fired a bad retcode, fire an event
                                                    self._fire_ret_load_specific_fun(load, fun_index)
                        Severity: Major
                        Found in salt/utils/event.py - About 45 mins to fix

                          Function __getitem__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def __getitem__(self, index):
                                  """
                                  Get the item at a given index.
                          
                                  If `index` is a slice, you will get back that slice of items. If it's
                          Severity: Minor
                          Found in salt/utils/oset.py - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function __getattribute__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def __getattribute__(self, key):
                                  try:
                                      return object.__getattribute__(self, key)
                                  except AttributeError as ex:
                                      if key == 'asynchronous':
                          Severity: Minor
                          Found in salt/utils/asynchronous.py - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function __load_uri has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def __load_uri(self, sock_dir, node):
                                  '''
                                  Return the string URI for the location of the pull and pub sockets to
                                  use for firing and listening to events
                                  '''
                          Severity: Minor
                          Found in salt/utils/event.py - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                                  if self.opts['master_stats']:
                                                      stats = salt.utils.event.update_stats(self.stats, start, _data)
                                                      self._post_stats(stats)
                          
                          
                          Severity: Major
                          Found in salt/utils/reactor.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if not isinstance(subnode, MappingNode):
                                                        raise ConstructorError("while constructing a mapping",
                                                                               node.start_mark,
                                                                               "expected a mapping for merging, but found {0}".format(subnode.id),
                                                                               subnode.start_mark)
                            Severity: Major
                            Found in salt/utils/yamlloader_old.py - About 45 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language