Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/win_task.py

Summary

Maintainability
F
3 days
Test Coverage

Function _get_task_state_prediction has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

def _get_task_state_prediction(state,
                              new_task):
    r'''
        predicts what a the new task will look like
Severity: Minor
Found in salt/states/win_task.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _task_state_prediction_bandage has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

def _task_state_prediction_bandage(state):
    r'''
    A bandage to format and add arguments to a task state.
    This is so task states can be compared.
Severity: Minor
Found in salt/states/win_task.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File win_task.py has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# https://msdn.microsoft.com/en-us/library/windows/desktop/aa383608(v=vs.85).aspx
from __future__ import absolute_import, print_function, unicode_literals
Severity: Minor
Found in salt/states/win_task.py - About 4 hrs to fix

    Function present has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def present(name,
            location='\\',
            user_name='System',
            password=None,
            force=False,
    Severity: Minor
    Found in salt/states/win_task.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _get_arguments has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def _get_arguments(arguments_given,
                   key_arguments,
                   arguments_need_it,
                   optional_arguments):
    block = {}
    Severity: Minor
    Found in salt/states/win_task.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if len(year) != 4:
                            year = time.strftime('%Y')[:2] + year
    Severity: Major
    Found in salt/states/win_task.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if key not in safe_keys and key in optional_keys:
                        if dic[key] == optional_keys[key]:
                            del dic[key]

        # removes add on arguments from triggers
      Severity: Major
      Found in salt/states/win_task.py - About 45 mins to fix

        Function absent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def absent(name,
           location='\\'):
    r'''
    Delete a task from the task scheduler.
        Severity: Minor
        Found in salt/states/win_task.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return ret
        Severity: Major
        Found in salt/states/win_task.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return ret
          Severity: Major
          Found in salt/states/win_task.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return ret
            Severity: Major
            Found in salt/states/win_task.py - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if not before['location_valid']:
        ret['result'] = False
        ret['comment'] = '{0} is not a valid file location'.format(repr(location))
        return ret
              Severity: Major
              Found in salt/states/win_task.py and 1 other location - About 1 hr to fix
              salt/states/win_task.py on lines 454..457

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if not before['location_valid']:
        ret['result'] = False
        ret['comment'] = '{0} is not a valid file location'.format(repr(location))
        return ret
              Severity: Major
              Found in salt/states/win_task.py and 1 other location - About 1 hr to fix
              salt/states/win_task.py on lines 343..346

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status