Sign upLogin

samcday/clusterphone

View on GitHub
Star
message-bus.js

Summary

Maintainability
C
1 day
Test Coverage

Function fireMessageHandler has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

function fireMessageHandler(nsName, seq, handler, cmd, payload, fd) {
  /* jshint validthis:true */

  var args = [payload, fd];
  if (this !== process) {
Severity: Minor
Found in message-bus.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fireMessageHandler has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function fireMessageHandler(nsName, seq, handler, cmd, payload, fd) {
  /* jshint validthis:true */

  var args = [payload, fd];
  if (this !== process) {
Severity: Minor
Found in message-bus.js - About 1 hr to fix

Function messageBus has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function messageBus(message, fd) {
  /* jshint validthis:true */

  /* istanbul ignore if */
  if (!message || !message.__clusterphone) {
Severity: Minor
Found in message-bus.js - About 1 hr to fix

Function handlerPromise has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var handlerPromise = new Promise(function(resolve, reject) {
    var ackSent = false,
        result;

    var acknowledge = function(reply) {
Severity: Minor
Found in message-bus.js - About 1 hr to fix

Function fireMessageHandler has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function fireMessageHandler(nsName, seq, handler, cmd, payload, fd) {
Severity: Minor
Found in message-bus.js - About 45 mins to fix

Function handleAck has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function handleAck(ackNum, message, namespace) {
  /* jshint validthis:true */

  debug("Handling ack for seq " + ackNum);
  var pending = namespace.getPending.call(this, ackNum);
Severity: Minor
Found in message-bus.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function messageBus has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function messageBus(message, fd) {
  /* jshint validthis:true */

  /* istanbul ignore if */
  if (!message || !message.__clusterphone) {
Severity: Minor
Found in message-bus.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return sendAck.call(this, nsName, seq, null, "Unhandled message type");
Severity: Major
Found in message-bus.js - About 30 mins to fix

There are no issues that match your filters.

Category
Status