samcday/node-etcd-leader

View on GitHub

Showing 3 of 3 total issues

Function _checkLeader has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

EtcdLeader.prototype._checkLeader = function(ourKey) {
  var self = this;
  this._leaderCheck = this._etcd.get(this._key, {sorted: true}, function(err, result) {
    self._leaderCheck = null;

Severity: Major
Found in index.js - About 2 hrs to fix

    Function stop has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    EtcdLeader.prototype.stop = function() {
      if (!this._started) {
        return;
      }
    
    
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function stop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      EtcdLeader.prototype.stop = function() {
        if (!this._started) {
          return;
        }
      
      
      Severity: Minor
      Found in index.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language