samsonframework/html2less

View on GitHub

Showing 4 of 4 total issues

Function analyzeSourceNode has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    protected function &analyzeSourceNode(\DOMNode $domNode, Node $parent)
    {
        /** @var Node[] $tagNodes Group current level nodes by tags */
        $tagNodes = [];

Severity: Minor
Found in src/Tree.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function optimizeGroupTags has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function optimizeGroupTags($tagNodes, Node $parent)
    {
        // Check if we have inner nodes with same tag
        foreach ($tagNodes as $tag => $nodes) {
            if (count($nodes) > 1) {
Severity: Minor
Found in src/Tree.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method analyzeSourceNode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function &analyzeSourceNode(\DOMNode $domNode, Node $parent)
    {
        /** @var Node[] $tagNodes Group current level nodes by tags */
        $tagNodes = [];

Severity: Minor
Found in src/Tree.php - About 1 hr to fix

    Function getDOMAttributeValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getDOMAttributeValue(\DOMNode $domNode, $attributeName)
        {
            if (null !== $domNode->attributes) {
                /**@var \DOMAttr $attribute */
                foreach ($domNode->attributes as $attribute) {
    Severity: Minor
    Found in src/Tree.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language