Sign upLogin

san650/ember-web-app

View on GitHub
Star
node-tests/unit/apple-meta-tags-test.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('does not return `web-app-capable` meta tag when display mode is fullscreen, but apple.webAppCapable is false', function() {
    var manifest = {
      display: 'fullscreen',
      apple: {
        webAppCapable: false
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 3 other locations - About 2 hrs to fix
node-tests/unit/apple-meta-tags-test.js on lines 74..86
node-tests/unit/apple-meta-tags-test.js on lines 88..100
node-tests/unit/apple-meta-tags-test.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('returns `web-app-capable` meta tag when display mode is browser, but apple.webAppCapable is true', function() {
    var manifest = {
      display: 'browser',
      apple: {
        webAppCapable: true
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 3 other locations - About 2 hrs to fix
node-tests/unit/apple-meta-tags-test.js on lines 60..72
node-tests/unit/apple-meta-tags-test.js on lines 74..86
node-tests/unit/apple-meta-tags-test.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('returns `web-app-capable` meta tag when display mode is browser, but apple.webAppCapable is true', function() {
    var manifest = {
      display: 'minimal-ui',
      apple: {
        webAppCapable: true
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 3 other locations - About 2 hrs to fix
node-tests/unit/apple-meta-tags-test.js on lines 60..72
node-tests/unit/apple-meta-tags-test.js on lines 74..86
node-tests/unit/apple-meta-tags-test.js on lines 88..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('does not return `web-app-capable` meta tag when display mode is standalone, but apple.webAppCapable is false', function() {
    var manifest = {
      display: 'standalone',
      apple: {
        webAppCapable: false
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 3 other locations - About 2 hrs to fix
node-tests/unit/apple-meta-tags-test.js on lines 60..72
node-tests/unit/apple-meta-tags-test.js on lines 88..100
node-tests/unit/apple-meta-tags-test.js on lines 102..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('returns `web-app-capable` meta tag when display mode is fullscreen', function() {
    var manifest = {
      display: 'fullscreen'
    };
    var expected = '<meta name="apple-mobile-web-app-capable" content="yes">';
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 4 other locations - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 18..27
node-tests/unit/apple-meta-tags-test.js on lines 29..38
node-tests/unit/apple-meta-tags-test.js on lines 40..49
node-tests/unit/apple-meta-tags-test.js on lines 116..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('does not return `web-app-capable` meta tag when display mode is browser', function() {
    var manifest = {
      display: 'browser'
    };
    var notExpected = '<meta name="apple-mobile-web-app-capable" content="yes">';
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 4 other locations - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 7..16
node-tests/unit/apple-meta-tags-test.js on lines 18..27
node-tests/unit/apple-meta-tags-test.js on lines 29..38
node-tests/unit/apple-meta-tags-test.js on lines 116..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('returns `web-app-capable` meta tag when display mode is standalone', function() {
    var manifest = {
      display: 'standalone'
    };
    var expected = '<meta name="apple-mobile-web-app-capable" content="yes">';
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 4 other locations - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 7..16
node-tests/unit/apple-meta-tags-test.js on lines 29..38
node-tests/unit/apple-meta-tags-test.js on lines 40..49
node-tests/unit/apple-meta-tags-test.js on lines 116..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('does not return `web-app-capable` meta tag when display mode is minimal-ui', function() {
    var manifest = {
      display: 'minimal-ui'
    };
    var notExpected = '<meta name="apple-mobile-web-app-capable" content="yes">';
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 4 other locations - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 7..16
node-tests/unit/apple-meta-tags-test.js on lines 18..27
node-tests/unit/apple-meta-tags-test.js on lines 40..49
node-tests/unit/apple-meta-tags-test.js on lines 116..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('returns `web-app-title` meta tag', function() {
    var manifest = { name: 'foo bar' };
    var expected = '<meta name="apple-mobile-web-app-title" content="foo bar">';

    var actual = appleMetaTags(manifest);
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 4 other locations - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 7..16
node-tests/unit/apple-meta-tags-test.js on lines 18..27
node-tests/unit/apple-meta-tags-test.js on lines 29..38
node-tests/unit/apple-meta-tags-test.js on lines 40..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('does not return `web-app-capable` meta tag when display mode is not defined', function() {
    var manifest = {};
    var notExpected = '<meta name="apple-mobile-web-app-capable" content="yes">';

    var actual = appleMetaTags(manifest);
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 1 other location - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 134..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('returns `web-app-status-bar-style` meta tag with default value', function() {
    var manifest = {};
    var expected = '<meta name="apple-mobile-web-app-status-bar-style" content="default">';

    var actual = appleMetaTags(manifest);
Severity: Major
Found in node-tests/unit/apple-meta-tags-test.js and 1 other location - About 1 hr to fix
node-tests/unit/apple-meta-tags-test.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status