Sign upLogin

sanger/limber

View on GitHub
Star
app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function extractChildUsedOligos has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function extractChildUsedOligos(parentUsedOligos, parentWellSubmDetails, tagLayout, tagSubstitutions, tagGroupOligos) {
  if (
    !isValidChildUsedOligoParameters(
      parentUsedOligos,
      parentWellSubmDetails,
Severity: Minor
Found in app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js - About 1 hr to fix

    Function extractParentWellSubmissionDetails has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function extractParentWellSubmissionDetails(parentPlate) {
  if (!parentPlate) {
    return {}
  }
    Severity: Minor
    Found in app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js - About 1 hr to fix

      Function extractSubmDetailsFromRequestsAsSource has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function extractSubmDetailsFromRequestsAsSource(well) {
  let submDetails = { id: null, usedTags: [] }

  const requestsLen = well.requests_as_source.length
  for (let i = 0; i < requestsLen; i++) {
      Severity: Minor
      Found in app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extractSubmDetailsFromAliquots has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function extractSubmDetailsFromAliquots(well) {
  let submDetails = { id: null, usedTags: [] }

  const requestsLen = well.aliquots.length
  for (let i = 0; i < requestsLen; i++) {
      Severity: Minor
      Found in app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isValidChildUsedOligoParameters has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        parentUsedOligos,
  parentWellSubmDetails,
  tagLayout,
  tagSubstitutions,
  tagGroupOligos
      Severity: Minor
      Found in app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js - About 35 mins to fix

        Function extractChildUsedOligos has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function extractChildUsedOligos(parentUsedOligos, parentWellSubmDetails, tagLayout, tagSubstitutions, tagGroupOligos) {
        Severity: Minor
        Found in app/frontend/javascript/custom-tagged-plate/tagClashFunctions.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status