Sign upLogin

sanger/limber

View on GitHub
Star
app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js

Summary

Maintainability
D
2 days
Test Coverage

Function byPool has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function byPool(well, tags, _relIndex, _absIndex, offset, counters) {
Severity: Minor
Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 45 mins to fix

    Function byPlateFixed has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function byPlateFixed(_well, tags, _relIndex, absIndex, offset, _counters) {
    Severity: Minor
    Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 45 mins to fix

      Function byFixedGroupByPlate has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function byFixedGroupByPlate(_well, tags, _relIndex, absIndex, offset, _counters) {
      Severity: Minor
      Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 45 mins to fix

        Function processTagsPerWell has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function processTagsPerWell(acc, well, relIndex, absIndex, tagsPerWell, walker) {
        Severity: Minor
        Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 45 mins to fix

          Function byGroupByPlate has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function byGroupByPlate(_well, tags, relIndex, _absIndex, offset, _counters) {
          Severity: Minor
          Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 45 mins to fix

            Function byPlateSeq has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function byPlateSeq(_well, tags, relIndex, _absIndex, offset, _counters) {
            Severity: Minor
            Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 45 mins to fix

              Function validateParameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              const validateParameters = function (data) {
  let result

  if (!data) {
    result = {
              Severity: Minor
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function byInverseColumns(wells, plateDims, tagsPerWell, walker) {
  return wells
    .sort(compareWellsByColumn)
    .reverse()
    .reduce((acc, well, relIndex) => {
              Severity: Major
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js and 1 other location - About 4 hrs to fix
              app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js on lines 76..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function byInverseRows(wells, plateDims, tagsPerWell, walker) {
  return wells
    .sort(compareWellsByRow)
    .reverse()
    .reduce((acc, well, relIndex) => {
              Severity: Major
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js and 1 other location - About 4 hrs to fix
              app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js on lines 96..106

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function byRows(wells, plateDims, tagsPerWell, walker) {
  return wells.sort(compareWellsByRow).reduce((acc, well, relIndex) => {
    const [wellCol, wellRow] = wellNameToCoordinate(well.position)
    const absIndex = wellCol + plateDims.number_of_columns * wellRow
    return processTagsPerWell(acc, well, relIndex, absIndex, tagsPerWell, walker)
              Severity: Major
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js and 1 other location - About 2 hrs to fix
              app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js on lines 88..94

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function byColumns(wells, plateDims, tagsPerWell, walker) {
  return wells.sort(compareWellsByColumn).reduce((acc, well, relIndex) => {
    const [wellCol, wellRow] = wellNameToCoordinate(well.position)
    const absIndex = wellRow + plateDims.number_of_rows * wellCol
    return processTagsPerWell(acc, well, relIndex, absIndex, tagsPerWell, walker)
              Severity: Major
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js and 1 other location - About 2 hrs to fix
              app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js on lines 68..74

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function compareWellsByRow(wellA, wellB) {
  const [wellACol, wellARow, wellBCol, wellBRow] = retrieveWellCoords(wellA, wellB)
  if (wellARow > wellBRow) {
    return 1
  } else if (wellBRow > wellARow) {
              Severity: Major
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js and 1 other location - About 2 hrs to fix
              app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js on lines 57..66

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function compareWellsByColumn(wellA, wellB) {
  const [wellACol, wellARow, wellBCol, wellBRow] = retrieveWellCoords(wellA, wellB)
  if (wellACol > wellBCol) {
    return 1
  } else if (wellBCol > wellACol) {
              Severity: Major
              Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js and 1 other location - About 2 hrs to fix
              app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js on lines 46..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status