Sign upLogin

sanger/limber

View on GitHub
Star

Showing 81 of 177 total issues

Function hasExpectedProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const hasExpectedProperties = (expectedProperties) => {
  return (results) => {
    if (results.length === 0) {
      return { valid: false, message: 'No results retrieved' }
    }
Severity: Minor
Found in app/frontend/javascript/shared/devourApiValidators.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method child_labware_of_plate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def child_labware_of_plate
      labware
        .wells
        .sort_by(&well_order)
        .each_with_object([]) do |well, plates|
Severity: Minor
Found in app/models/robots/bed/pooling_and_splitting.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findResults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const findResults = (cy, filter) => {
  if (notResults !== undefined) {
    notResults.restore()
  }
Severity: Minor
Found in app/frontend/javascript/pipeline-graph/filterFunctions.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method valid_robot has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_robot
      return false unless robot_present_if_required

      return true unless verify_robot? && beds.values.first.labware.present?
Severity: Minor
Found in app/models/robots/robot.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateParameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const validateParameters = function (data) {
  let result

  if (!data) {
    result = {
Severity: Minor
Found in app/frontend/javascript/custom-tagged-plate/tagLayoutFunctions.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return includes.include?(current_state) if includes.present?
Severity: Major
Found in app/models/concerns/presenters/statemachine/feature_in_states.rb - About 30 mins to fix

    Method compute_well_amounts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def compute_well_amounts(wells, multiplication_factor)
      # sort on well coordinate to ensure wells are in plate column order
      wells
        .sort_by(&:coordinate)
        .each_with_object({}) do |well, well_amounts|
    Severity: Minor
    Found in app/models/utility/concentration_binning_calculator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tubes_must_be_of_expected_purpose_type has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def tubes_must_be_of_expected_purpose_type
      return unless file_valid?

      parent_tubes.each do |foreign_barcode, tube_in_db|
        # NB. should be catching missing tubes in previous validation
    Severity: Minor
    Found in app/models/labware_creators/multi_stamp_tubes_using_tube_rack_scan.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compute_well_amounts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def compute_well_amounts(wells)
      # sort on well coordinate to ensure wells are in plate column order
      wells
        .sort_by(&:coordinate)
        .each_with_object({}) do |well, well_amounts|
    Severity: Minor
    Found in app/models/utility/fixed_normalisation_calculator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method concentration_bins has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def concentration_bins(well_amounts) # rubocop:todo Metrics/AbcSize
      # Returns eg. { 1 => [], 2 => [], 3 => [] }
      conc_bins = (1..number_of_bins).index_with { |_bin_number| [] }
      well_amounts.each do |well_locn, amount|
        bins_template.each_with_index do |bin_template, bin_index|
    Severity: Minor
    Found in app/models/utility/concentration_binning_calculator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkForUnacceptablePlatePurpose has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const checkForUnacceptablePlatePurpose = (acceptable_purposes) => {
  return (plate) => {
    if (!acceptable_purposes || acceptable_purposes.length == 0) {
      // return valid if no acceptable purposes are provided
      return validScanMessage()
    Severity: Minor
    Found in app/frontend/javascript/shared/components/plateScanValidators.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compute_bin_details_by_well has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def compute_bin_details_by_well(well_amounts)
      well_amounts.each_with_object({}) do |(well_locn, amount), well_colours|
        bins_template.each do |bin_template|
          next unless (bin_template['min']...bin_template['max']).cover?(amount)
    Severity: Minor
    Found in app/models/utility/common_dilution_calculations.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method concentration_bins has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def concentration_bins(norm_details)
      # Returns eg. { 1 => [], 2 => [], 3 => [] }
      conc_bins = (1..number_of_bins).index_with { |_bin_number| [] }
      norm_details.each do |well_locn, details|
        amount = details['amount_in_target']
    Severity: Minor
    Found in app/models/utility/normalised_binning_calculator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method child_labware_of_plate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def child_labware_of_plate
      labware
        .wells
        .sort_by(&well_order)
        .each_with_object([]) do |well, plates|
    Severity: Minor
    Found in app/models/robots/bed/splitting.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method active_wells_with_terminated_requests has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def active_wells_with_terminated_requests(labware)
      labware.wells.filter_map do |well|
        next if well.inactive? || well.active_requests.empty?

        well.location if well.active_requests.all?(&:failed?)
    Severity: Minor
    Found in app/models/validators/failed_validator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tubes_must_have_active_requests_of_expected_type has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def tubes_must_have_active_requests_of_expected_type
      return unless file_valid?

      parent_tubes.each do |foreign_barcode, tube_in_db|
        # NB. should be catching missing tubes in previous validation
    Severity: Minor
    Found in app/models/labware_creators/multi_stamp_tubes_using_tube_rack_scan.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkQCableWalkingBy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const checkQCableWalkingBy = (allowedWalkingByList) => {
  return (qcable) => {
    if (!qcable.lot || !qcable.lot.tag_layout_template || !qcable.lot.tag_layout_template.walking_by) {
      return {
        valid: false,
    Severity: Minor
    Found in app/frontend/javascript/shared/components/plateScanValidators.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_for_unused_parents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def check_for_unused_parents
      parent_beds.each do |parent_bed|
        next if beds[parent_bed].empty?
        next if used_parents.include?(parent_bed)
    Severity: Minor
    Found in app/models/robots/pooling_and_splitting_robot.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function requestsFromPlates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const requestsFromPlates = function (plateObjs) {
  const requestsArray = []
  for (let p = 0; p < plateObjs.length; p++) {
    const plateObj = plateObjs[p]
    const wells = plateObj.plate.wells
    Severity: Minor
    Found in app/frontend/javascript/shared/requestHelpers.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalisation_details has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def normalisation_details(wells) # rubocop:todo Metrics/AbcSize
      # sort on well coordinate to ensure wells are in plate column order
      wells
        .sort_by(&:coordinate)
        .each_with_object({}) do |well, details|
    Severity: Minor
    Found in app/models/utility/common_dilution_calculations.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language