BatchCreationValidator#batch_meets_minimum_size calls 'record.min_size' 3 times New
return unless record.min_size && (record.requests.size < record.min_size)
record.errors.add :base, "You must create batches of at least #{record.min_size}
- Read upRead up
- Exclude checks
Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.
Reek implements a check for Duplicate Method Call.
Example
Here's a very much simplified and contrived example. The following method will report a warning:
def double_thing()
@other.thing + @other.thing
end
One quick approach to silence Reek would be to refactor the code thus:
def double_thing()
thing = @other.thing
thing + thing
end
A slightly different approach would be to replace all calls of double_thing
by calls to @other.double_thing
:
class Other
def double_thing()
thing + thing
end
end
The approach you take will depend on balancing other factors in your code.
BatchCreationValidator#requests_have_same_flowcell_type doesn't depend on instance state (maybe move it to another class?) New
def requests_have_same_flowcell_type(record)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
BatchCreationValidator#all_requests_are_ready? doesn't depend on instance state (maybe move it to another class?) New
def all_requests_are_ready?(record)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
BatchCreationValidator#requests_have_same_target_purpose doesn't depend on instance state (maybe move it to another class?) New
def requests_have_same_target_purpose(record)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
BatchCreationValidator#requests_have_same_read_length doesn't depend on instance state (maybe move it to another class?) New
def requests_have_same_read_length(record)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
BatchCreationValidator#batch_meets_minimum_size doesn't depend on instance state (maybe move it to another class?) New
def batch_meets_minimum_size(record)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.