sanger/sequencescape

View on GitHub
Fix another test that was broken by adding server side validation to these fields #4814
Katy Taylor authored 184bd681
complete00:01:14
1
git clone
2
codeclimate validate-config
View output
codeclimate validate-config
No errors or warnings found in .codeclimate.yml.
3
codeclimate prepare
View output
codeclimate prepare
4
builder pull-engines
View output
determining required images
5
structure
View output
12
Parser process id: 12
codeclimate-parser socket not present
waiting 1s...
W, [2024-04-16T12:52:49.225523 #1]  WARN -- : Skipping app/models/request_type/validator.rb due to CC::Parser::Client::HTTPError
W, [2024-04-16T12:52:49.225562 #1]  WARN -- : Response status: 422
W, [2024-04-16T12:52:52.762870 #1]  WARN -- : Skipping app/models/submission/order_presenter.rb due to CC::Parser::Client::HTTPError
W, [2024-04-16T12:52:52.762910 #1]  WARN -- : Response status: 422
W, [2024-04-16T12:52:57.927575 #1]  WARN -- : Skipping app/api/core/abilities.rb due to CC::Parser::Client::HTTPError
W, [2024-04-16T12:52:57.927691 #1]  WARN -- : Response status: 422
W, [2024-04-16T12:52:58.352319 #1]  WARN -- : Skipping app/api/core/endpoint/basic_handler/actions/guards.rb due to CC::Parser::Client::HTTPError
W, [2024-04-16T12:52:58.352355 #1]  WARN -- : Response status: 422
6
duplication
View output
12
Parser process id: 12
codeclimate-parser socket not present
waiting 1s...
I, [2024-04-16T12:53:06.065454 #1]  INFO -- : Skipping file ./app/uat_actions/uat_actions/generate_tubes.rb due to exception (Racc::ParseError): ./app/uat_actions/uat_actions/generate_tubes.rb:11 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:07.116022 #1]  INFO -- : Skipping file ./app/models/request_type/validator.rb due to exception (Racc::ParseError): ./app/models/request_type/validator.rb:21 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:07.390841 #1]  INFO -- : Skipping file ./app/models/tube_rack.rb due to exception (Racc::ParseError): ./app/models/tube_rack.rb:10 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:07.703424 #1]  INFO -- : Skipping file ./app/models/cherrypick/volume_by_nano_grams.rb due to exception (Racc::ParseError): ./app/models/cherrypick/volume_by_nano_grams.rb:84 :: parse error on value ")" (tRPAREN)

I, [2024-04-16T12:53:07.807556 #1]  INFO -- : Skipping file ./app/models/plate_volume.rb due to exception (Racc::ParseError): ./app/models/plate_volume.rb:9 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:08.105292 #1]  INFO -- : Skipping file ./app/models/plate/quad_creator.rb due to exception (Racc::ParseError): ./app/models/plate/quad_creator.rb:10 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:08.648399 #1]  INFO -- : Skipping file ./app/models/pulldown/plate_purposes.rb due to exception (Racc::ParseError): ./app/models/pulldown/plate_purposes.rb:75 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:09.400320 #1]  INFO -- : Skipping file ./app/models/submission/order_presenter.rb due to exception (Racc::ParseError): ./app/models/submission/order_presenter.rb:20 :: parse error on value "..." (tDOT3)

I, [2024-04-16T12:53:09.834352 #1]  INFO -- : Skipping file ./app/models/qc_report/file.rb due to exception (Racc::ParseError): ./app/models/qc_report/file.rb:36 :: parse error on value ["rescue", 36] (kRESCUE)

I, [2024-04-16T12:53:12.390576 #1]  INFO -- : Skipping file ./app/api/core/abilities.rb due to exception (Racc::ParseError): ./app/api/core/abilities.rb:46 :: parse error on value "..." (tDOT3)

I, [2024-04-16T12:53:12.657107 #1]  INFO -- : Skipping file ./app/api/core/endpoint/basic_handler/actions/guards.rb due to exception (Racc::ParseError): ./app/api/core/endpoint/basic_handler/actions/guards.rb:29 :: parse error on value ":" (tCOLON)

I, [2024-04-16T12:53:13.198672 #1]  INFO -- : Skipping file ./app/sequencescape_excel/sequencescape_excel/column_list.rb due to exception (Racc::ParseError): ./app/sequencescape_excel/sequencescape_excel/column_list.rb:8 :: parse error on value ":" (tCOLON)
7
fixme
fixme engine documentation
8
reek
reek engine documentation
View output
!!!
        Source 'app/models/request_type/validator.rb' cannot be processed by Reek due to a syntax error in the source file.

        This is a problem that is outside of Reek's scope and should be fixed by you, the
        user, in order for Reek being able to continue.

        Things you can try:
        - Check the syntax of the problematic file
        - If the file is not in fact a Ruby file, exclude it in your .reek.yml file

        Exception message:

        #<Parser::SyntaxError: unexpected token tDOT3>

        Original backtrace:

        /usr/local/bundle/gems/parser-3.0.2.0/lib/parser/diagnostic/engine.rb:72:in `process'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:286:in `on_error'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:190:in `parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:207:in `parse_with_comments'
	/usr/src/app/lib/reek/source/source_code.rb:117:in `parse'
	/usr/src/app/lib/reek/source/source_code.rb:53:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:116:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:120:in `examine_tree'
	/usr/src/app/lib/reek/examiner.rb:94:in `block in run'
	/usr/src/app/lib/reek/examiner.rb:104:in `wrap_exceptions'
	/usr/src/app/lib/reek/examiner.rb:93:in `run'
	/usr/src/app/lib/reek/examiner.rb:61:in `smells'
	/usr/src/app/lib/reek/examiner.rb:69:in `smells_count'
	/usr/src/app/lib/reek/report/base_report.rb:44:in `add_examiner'
	/usr/src/app/lib/reek/cli/command/report_command.rb:26:in `block in populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `each'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:17:in `execute'
	/usr/src/app/lib/reek/cli/application.rb:32:in `execute'
	/usr/src/app/bin/code_climate_reek:68:in `<main>'

        !!!
        !!!
        Source 'app/models/submission/order_presenter.rb' cannot be processed by Reek due to a syntax error in the source file.

        This is a problem that is outside of Reek's scope and should be fixed by you, the
        user, in order for Reek being able to continue.

        Things you can try:
        - Check the syntax of the problematic file
        - If the file is not in fact a Ruby file, exclude it in your .reek.yml file

        Exception message:

        #<Parser::SyntaxError: unexpected token tDOT3>

        Original backtrace:

        /usr/local/bundle/gems/parser-3.0.2.0/lib/parser/diagnostic/engine.rb:72:in `process'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:286:in `on_error'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:190:in `parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:207:in `parse_with_comments'
	/usr/src/app/lib/reek/source/source_code.rb:117:in `parse'
	/usr/src/app/lib/reek/source/source_code.rb:53:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:116:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:120:in `examine_tree'
	/usr/src/app/lib/reek/examiner.rb:94:in `block in run'
	/usr/src/app/lib/reek/examiner.rb:104:in `wrap_exceptions'
	/usr/src/app/lib/reek/examiner.rb:93:in `run'
	/usr/src/app/lib/reek/examiner.rb:61:in `smells'
	/usr/src/app/lib/reek/examiner.rb:69:in `smells_count'
	/usr/src/app/lib/reek/report/base_report.rb:44:in `add_examiner'
	/usr/src/app/lib/reek/cli/command/report_command.rb:26:in `block in populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `each'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:17:in `execute'
	/usr/src/app/lib/reek/cli/application.rb:32:in `execute'
	/usr/src/app/bin/code_climate_reek:68:in `<main>'

        !!!
        !!!
        Source 'app/api/core/abilities.rb' cannot be processed by Reek due to a syntax error in the source file.

        This is a problem that is outside of Reek's scope and should be fixed by you, the
        user, in order for Reek being able to continue.

        Things you can try:
        - Check the syntax of the problematic file
        - If the file is not in fact a Ruby file, exclude it in your .reek.yml file

        Exception message:

        #<Parser::SyntaxError: unexpected token tDOT3>

        Original backtrace:

        /usr/local/bundle/gems/parser-3.0.2.0/lib/parser/diagnostic/engine.rb:72:in `process'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:286:in `on_error'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:190:in `parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:207:in `parse_with_comments'
	/usr/src/app/lib/reek/source/source_code.rb:117:in `parse'
	/usr/src/app/lib/reek/source/source_code.rb:53:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:116:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:120:in `examine_tree'
	/usr/src/app/lib/reek/examiner.rb:94:in `block in run'
	/usr/src/app/lib/reek/examiner.rb:104:in `wrap_exceptions'
	/usr/src/app/lib/reek/examiner.rb:93:in `run'
	/usr/src/app/lib/reek/examiner.rb:61:in `smells'
	/usr/src/app/lib/reek/examiner.rb:69:in `smells_count'
	/usr/src/app/lib/reek/report/base_report.rb:44:in `add_examiner'
	/usr/src/app/lib/reek/cli/command/report_command.rb:26:in `block in populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `each'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:17:in `execute'
	/usr/src/app/lib/reek/cli/application.rb:32:in `execute'
	/usr/src/app/bin/code_climate_reek:68:in `<main>'

        !!!
        !!!
        Source 'app/api/core/endpoint/basic_handler/actions/guards.rb' cannot be processed by Reek due to a syntax error in the source file.

        This is a problem that is outside of Reek's scope and should be fixed by you, the
        user, in order for Reek being able to continue.

        Things you can try:
        - Check the syntax of the problematic file
        - If the file is not in fact a Ruby file, exclude it in your .reek.yml file

        Exception message:

        #<Parser::SyntaxError: unexpected token tDOT3>

        Original backtrace:

        /usr/local/bundle/gems/parser-3.0.2.0/lib/parser/diagnostic/engine.rb:72:in `process'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:286:in `on_error'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
	/usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:190:in `parse'
	/usr/local/bundle/gems/parser-3.0.2.0/lib/parser/base.rb:207:in `parse_with_comments'
	/usr/src/app/lib/reek/source/source_code.rb:117:in `parse'
	/usr/src/app/lib/reek/source/source_code.rb:53:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:116:in `syntax_tree'
	/usr/src/app/lib/reek/examiner.rb:120:in `examine_tree'
	/usr/src/app/lib/reek/examiner.rb:94:in `block in run'
	/usr/src/app/lib/reek/examiner.rb:104:in `wrap_exceptions'
	/usr/src/app/lib/reek/examiner.rb:93:in `run'
	/usr/src/app/lib/reek/examiner.rb:61:in `smells'
	/usr/src/app/lib/reek/examiner.rb:69:in `smells_count'
	/usr/src/app/lib/reek/report/base_report.rb:44:in `add_examiner'
	/usr/src/app/lib/reek/cli/command/report_command.rb:26:in `block in populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `each'
	/usr/src/app/lib/reek/cli/command/report_command.rb:25:in `populate_reporter_with_smells'
	/usr/src/app/lib/reek/cli/command/report_command.rb:17:in `execute'
	/usr/src/app/lib/reek/cli/application.rb:32:in `execute'
	/usr/src/app/bin/code_climate_reek:68:in `<main>'

        !!!
9
bundler-audit
bundler-audit engine documentation
10
flog
flog engine documentation
View output
ERROR: parsing ruby file app/models/request_type/validator.rb
Racc::ParseError: app/models/request_type/validator.rb:77 :: parse error on value "..." (tDOT3) at:
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:528:in `on_error'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1179:in `on_error'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1086:in `block in process'
ERROR: parsing ruby file app/models/submission/order_presenter.rb
Racc::ParseError: app/models/submission/order_presenter.rb:20 :: parse error on value "..." (tDOT3) at:
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:528:in `on_error'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1179:in `on_error'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1086:in `block in process'
ERROR: parsing ruby file app/api/core/abilities.rb
Racc::ParseError: app/api/core/abilities.rb:46 :: parse error on value "..." (tDOT3) at:
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:528:in `on_error'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1179:in `on_error'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1086:in `block in process'
ERROR: parsing ruby file app/api/core/endpoint/basic_handler/actions/guards.rb
Racc::ParseError: app/api/core/endpoint/basic_handler/actions/guards.rb:47 :: parse error on value "..." (tDOT3) at:
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:528:in `on_error'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1179:in `on_error'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `_racc_do_parse_c'
  /usr/local/lib/ruby/2.6.0/racc/parser.rb:259:in `do_parse'
  /usr/local/bundle/gems/ruby_parser-3.13.1/lib/ruby_parser_extras.rb:1086:in `block in process'