Showing 283 of 5,433 total issues
Method check_data_release_and_accession_for_submission
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def check_data_release_and_accession_for_submission # rubocop:todo Metrics/AbcSize
return if configatron.disable_accession_check == true
if not study.valid_data_release_properties?
errors.add(:study, "#{study.name}: Please fill in the study data release information")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method rack_well
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def rack_well(well_data) # rubocop:todo Metrics/MethodLength
return unless well_data && well_data['sample_tube_uuid']
raise SampleTubeNotExists unless well_data['sample_tube_resource']
sample_tube = well_data['sample_tube_resource']
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method alternate_position
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def alternate_position(well_position, size, *dimensions)
return nil unless Map.valid_well_position?(well_position)
divisor, multiplier = dimensions.map { |n| send(:"plate_#{n}", size) }
column, row = (well_position - 1).divmod(divisor)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_details
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def build_details(asset)
{
project_name: asset.projects.one? ? asset.projects.first.name : '',
study_name: asset.studies.one? ? asset.studies.first.name : '',
barcode: asset.labware_human_barcode,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_columns
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def create_columns(columns, conditional_formattings) # rubocop:todo Metrics/MethodLength
columns.each do |k, v|
add_with_number(
if v.is_a?(Hash)
SequencescapeExcel::Column.new(SequencescapeExcel::Column.build_arguments(v, k, conditional_formattings))
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_link
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add_link(menu, l, o, options) # rubocop:todo Metrics/MethodLength
menu ||= Informatics::View::Menu::List.new
if options.nil?
menu.add_item text: l.first_key, link: l.first_value
elsif o.key_is_present?(:confirm)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method handle_belongs_to
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def handle_belongs_to(attributes, attribute, json, object) # rubocop:todo Metrics/MethodLength
if json.is_a?(Hash)
uuid = json.delete('uuid')
associated = association_class(attribute, object)
if uuid.present?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method taxon_lookup
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def taxon_lookup # rubocop:todo Metrics/AbcSize
if params[:term]
url = configatron.taxon_lookup_url + "/esearch.fcgi?db=taxonomy&term=#{params[:term].gsub(/\s/, '_')}"
elsif params[:id]
url = configatron.taxon_lookup_url + "/efetch.fcgi?db=taxonomy&mode=xml&id=#{params[:id]}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_if_present
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def process_if_present(json, path)
value =
path.inject(json) do |current, step|
return unless current.respond_to?(:key?) # Could be nested attribute but not present!
return unless current.key?(step)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_row_retention_value
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def check_row_retention_value(row, plate_barcode, retention_instructions)
# if present the column is mandatory
row_retention_value = row.value('retention_instruction')
return 'Value cannot be blank.' if row_retention_value.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method lookup
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def lookup # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
return unless params[:asset] && params[:asset][:barcode]
@assets = Labware.with_barcode(params[:asset][:barcode]).limit(50).page(params[:page])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method lookup
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def lookup # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
return unless params[:asset] && params[:asset][:barcode]
@assets = Labware.with_barcode(params[:asset][:barcode]).limit(50).page(params[:page])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def index # rubocop:todo Metrics/CyclomaticComplexity, Metrics/MethodLength
@study, @item = nil, nil
# Ok, here we pick the initial source for the Requests. They either come from Request (as in all Requests), or they
# are limited by the Asset / Item.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method managed_update
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def managed_update # rubocop:todo Metrics/AbcSize
@project = Project.find(params[:id])
authorize! :managed_update, @project
if params[:project][:uploaded_data].present?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method pagination_actions
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def pagination_actions
{
first: action_for_page(1),
last: action_for_page(@last_page),
read: action_for_page(@current_page)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method action_for_qc_state
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def action_for_qc_state(state) # rubocop:todo Metrics/MethodLength
ActiveRecord::Base.transaction do
if @last_event.present?
# If we already have an event we check to see its state. If it matches,
# we just continue to rendering, otherwise we blow up.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def index # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
if params[:study_id]
@study = Study.find(params[:study_id])
@assets = @study.assets_through_aliquots.order(:name).page(params[:page])
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update # rubocop:todo Metrics/AbcSize
@request = Request.find(params[:id])
authorize! :update, @request
unless params[:request][:request_type_id].nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method cancel
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def cancel # rubocop:todo Metrics/AbcSize
@request = Request.find(params[:id])
if @request.try(:may_cancel_before_started?)
if @request.cancel_before_started && @request.save
flash[:notice] = "Request #{@request.id} has been cancelled"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add(type, link, options = nil) # rubocop:todo Metrics/CyclomaticComplexity
o = Informatics::Support::Options.collect(options)
l = Informatics::Support::Options.collect(link)
case type
when :menu
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"