Showing 282 of 5,432 total issues
Method perform_pick
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
def perform_pick(requests, robot, control_source_plate, workflow_controller) # rubocop:todo Metrics/AbcSize
max_plates = robot.max_beds
raise StandardError, 'The chosen robot has no beds!' if max_plates.zero?
destination_plates = []
Method render_class_for_model
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def render_class_for_model(model) # rubocop:todo Metrics/CyclomaticComplexity
render_class = Class.new(self)
# NOTE: It's quite annoying that you don't have any access to the inheritable class attributes from
# within the Class.new block above, so we have to do a separate instance_eval to get it to work.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method record_tube_samples
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def record_tube_samples # rubocop:todo Metrics/AbcSize
tube_counter = 0
first_to_last.each do |sheet_row|
row = dynamic_attributes[sheet_row]
build_tube_sample_manifest_asset do |sample_manifest_asset|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def update # rubocop:todo Metrics/AbcSize
@study = Study.find(params[:id])
ActiveRecord::Base.transaction do
@study.update!(params[:study])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generate_picking_data_hash
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def generate_picking_data_hash(target_barcode, requests: requests_for_destination_plate)
data_objects = {}
source_barcode_to_pick_number = {}
current_pick_size = lambda { data_objects[data_objects.size]['source'].size }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
def process # rubocop:todo Metrics/CyclomaticComplexity
# Store the details of the successful submissions so the user can be presented with a summary
@submission_ids = []
@completed_submissions = {}
Method create_request_chain!
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create_request_chain!(request_type_and_multiplier_pairs, source_data_set, multiplexing_assets, &block) # rubocop:todo Metrics/CyclomaticComplexity
raise StandardError, 'No request types specified!' if request_type_and_multiplier_pairs.empty?
request_type, multiplier = request_type_and_multiplier_pairs.shift
Method serialize
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.serialize(st) # rubocop:todo Metrics/CyclomaticComplexity
attributes = st.attributes
new_attributes = {}
STRAIGHT_CLONE.each do |key|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method duplicate_barcodes
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def duplicate_barcodes # rubocop:todo Metrics/CyclomaticComplexity
return unless upload.respond_to?(:rows)
unique_bcs = []
upload.rows.each do |row|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method non_matching_retention_instructions
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def non_matching_retention_instructions
return nil, nil unless upload.respond_to?(:rows)
upload
.rows
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method non_matching_retention_instructions_for_plates
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def non_matching_retention_instructions_for_plates
return nil, nil unless upload.respond_to?(:rows)
# Initialize empty retention_instructions hash to store retention instructions
upload
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _check_mandatory_field
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def _check_mandatory_field(mandatory_field) # rubocop:todo Metrics/CyclomaticComplexity, Metrics/AbcSize
return unless upload.respond_to?(:rows)
upload.rows.each do |row|
next if row.columns.blank? || row.data.blank?
col_num = row.columns.find_column_or_null(:name, mandatory_field).number
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method swap
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def swap(current_user, batch_info = {}) # rubocop:todo Metrics/CyclomaticComplexity
return false if batch_info.empty?
# Find the two lanes that are to be swapped
batch_request_left =
Method included
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.included(base) # rubocop:todo Metrics/MethodLength
base.class_eval do
def mx_library
asset.external_identifier || 'UNKNOWN'
end
Function exports
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function (api) {
var validEnv = ["development", "test", "production"];
var currentEnv = api.env();
var isDevelopmentEnv = api.env("development");
var isProductionEnv = api.env("production");
Method build_association
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def build_association(as_class, options) # rubocop:todo Metrics/MethodLength
# First we build the association into the current ActiveRecord::Base class
as_name = as_class.name.demodulize.underscore
association_name = "#{as_name}_metadata".underscore.to_sym
class_name = "#{name}::Metadata"
Method included
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.included(base) # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
base.class_eval do
## State machine
## namespace: true as destroyed clashes with rails, but we can't easily rename the state
aasm column: :state, whiny_persistence: true, namespace: true, name: 'qc_state' do
Function plateBarcodeScan
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
plateBarcodeScan: async ({ commit, dispatch, state }, plate_barcode) => {
// Firstly we record that the plate has been scanned.
commit("scanPlate", { barcode: plate_barcode });
const scanned_plate_id = state.scanStore[`_${plate_barcode}`].id;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_each
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def validate_each(record, attribute, value)
return unless check_hash(record, attribute, value)
value.each do |program, params|
record.errors.add attribute, "invalid label #{program}" unless program.in?(PROGRAMS_LABELS)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def update(_attributes = {}) # rubocop:todo Metrics/CyclomaticComplexity, Metrics/MethodLength
return unless valid? && foreign_barcode_format.present?
# if this tube's list of barcodes already contains a foreign barcode with the same format then update the
# existing one
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"