Sign upLogin

sapristi-tool/sapristi

View on GitHub
Star

Showing 2 of 114 total issues

Method parse_integer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.parse_integer(value, min = nil, max = nil)
      raise OptionParser::InvalidOption, "'#{value}' is not an integer" unless value.match(/^[0-9]+$/)

      integer = value.to_i
      raise OptionParser::InvalidOption, "requires a wait time > 0, provided=#{value}" unless min.nil? || integer >= min
Severity: Minor
Found in lib/sapristi/arguments_parser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method window_for? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def window_for?(waiter, program, title, window)
      window_pgroup = Process.getpgid(window.pid)
      log.debug "Found new window: pid=#{window.pid}, ppid=#{window_pgroup}, id=#{window.id}, title=#{window.title}"
      if window_for_waiter?(waiter, window)
        log.debug "Found window by pid=#{waiter.pid}, id=#{window.id}, title=#{window.title}"
Severity: Minor
Found in lib/sapristi/new_process_window_detector.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language