Sign upLogin

saraileon/mexico-zipcodes

View on GitHub
Star

Showing 3 of 3 total issues

Function search has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  search( searchType, searchCriteria, param, page, limit ) {
    return new Promise((resolve, reject) => {
      let data  = {};
      let total = 0;
      let query = {};
Severity: Minor
Found in helpers/search.js - About 1 hr to fix

    Function handler has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      handler: function(req, res) {
    let   searchType = String(req.params.type);
    const searchStr  = String(req.params.search);
    let page         = req.query.page;
    let limit        = req.query.limit;
    Severity: Minor
    Found in controllers/app.js - About 1 hr to fix

      Function search has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        search( searchType, searchCriteria, param, page, limit ) {
    return new Promise((resolve, reject) => {
      let data  = {};
      let total = 0;
      let query = {};
      Severity: Minor
      Found in helpers/search.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language