Sign upLogin

sarulabs/statix

View on GitHub
Star

Showing 6 of 8 total issues

Function ExecCommand has 58 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ExecCommand(name string, args ...interface{}) (resource.Resource, error) {
    parsedArgs, err := parseArgs(args...)
    if err != nil {
        return &resource.Empty{}, err
    }
Severity: Minor
Found in alteration/command.go - About 1 hr to fix

    Method AssetPack.Dump has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
    Open

    func (ap AssetPack) Dump(filters []Filter) error {
    var r resource.Resource

    files, err := ap.InputFiles()
    if err != nil {
    Severity: Minor
    Found in asset.go - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ExecCommand has 9 return statements (exceeds 4 allowed).
    Open

    func ExecCommand(name string, args ...interface{}) (resource.Resource, error) {
    parsedArgs, err := parseArgs(args...)
    if err != nil {
        return &resource.Empty{}, err
    }
    Severity: Major
    Found in alteration/command.go - About 55 mins to fix

      Method AssetPack.Dump has 8 return statements (exceeds 4 allowed).
      Open

      func (ap AssetPack) Dump(filters []Filter) error {
    var r resource.Resource

    files, err := ap.InputFiles()
    if err != nil {
      Severity: Major
      Found in asset.go - About 50 mins to fix

        Method JpegOptim.Alter has 6 return statements (exceeds 4 allowed).
        Open

        func (jpegOptim JpegOptim) Alter(r resource.Resource) (resource.Resource, error) {
    // create temporary file
    f, err := helpers.TempFile("", "statix_filter_", ".jpg")
    if err != nil {
        return &resource.Empty{}, err
        Severity: Major
        Found in alteration/jpegoptim.go - About 40 mins to fix

          Method SingleAsset.Dump has 5 return statements (exceeds 4 allowed).
          Open

          func (sa SingleAsset) Dump(filters []Filter) error {
    r := sa.Input

    output, err := sa.OutputFile("")
    for _, f := range filters {
          Severity: Major
          Found in asset.go - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language