Sign upLogin

scambra/devise_invitable

View on GitHub
Star

Showing 8 of 8 total issues

Method invite! has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

      def invite!(invited_by = nil, options = {})
        # This is an order-dependant assignment, this can't be moved
        was_invited = invited_to_sign_up?

        # Required to workaround confirmable model's confirmation_required? method
Severity: Minor
Found in lib/devise_invitable/models.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File models.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'active_support/deprecation'
require 'devise_invitable/models/authenticatable'

module Devise
  module Models
Severity: Minor
Found in lib/devise_invitable/models.rb - About 2 hrs to fix

    Method update has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    raw_invitation_token = update_resource_params[:invitation_token]
    self.resource = accept_resource
    invitation_accepted = resource.errors.empty?
    Severity: Minor
    Found in app/controllers/devise/invitations_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _invite has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def _invite(attributes = {}, invited_by = nil, options = {}, &block)
          invite_key_array = invite_key_fields
          attributes_hash = {}
          invite_key_array.each do |k,v|
            attribute = attributes.delete(k)
    Severity: Minor
    Found in lib/devise_invitable/models.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_resource has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_resource(hash = {})
      if hash[:email]
        self.resource = resource_class.where(email: hash[:email]).first
        if self.resource && self.resource.respond_to?(:invited_to_sign_up?) && self.resource.invited_to_sign_up?
          self.resource.attributes = hash
    Severity: Minor
    Found in app/controllers/devise_invitable/registrations_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    self.resource = invite_resource
    resource_invited = resource.errors.empty?

    yield resource if block_given?
    Severity: Minor
    Found in app/controllers/devise/invitations_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method accept_invitation! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def accept_invitation!
        if self.invited_to_sign_up?
          @accepting_invitation = true
          run_callbacks :invitation_accepted do
            self.accept_invitation
    Severity: Minor
    Found in lib/devise_invitable/models.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method attributes_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def attributes_for(kind)
          case kind
          when :invite
            resource_class.respond_to?(:invite_key_fields) ? resource_class.invite_key_fields : []
          when :accept_invitation
    Severity: Minor
    Found in lib/devise_invitable/parameter_sanitizer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language