schahriar/supertask-cluster

View on GitHub
lib/CommunicationModel.js

Summary

Maintainability
D
2 days
Test Coverage

Function STC_COM_SEND has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

CommunicationModel.prototype.send = function STC_COM_SEND(id, message, timeout, callback) {
    // Check if ID is valid
    if((!this.cluster.workers[id]) && (id !== 'master')) {
        if(callback) {
            return callback(new Error('Worker with the given ID was not found.'));
Severity: Minor
Found in lib/CommunicationModel.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function STC_COM_INCOMING has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

CommunicationModel.prototype.incoming = function STC_COM_INCOMING(id, message) {
    if(message.ticket && !message.type) {
        this.emit('CLUSTER_CALLBACK::' + id + "::" + message.ticket, message);
    }else if(message.type === 'buffer') {
        var callback = this.callback(id, message.ticket);
Severity: Minor
Found in lib/CommunicationModel.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function STC_COM_INCOMING has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

CommunicationModel.prototype.incoming = function STC_COM_INCOMING(id, message) {
    if(message.ticket && !message.type) {
        this.emit('CLUSTER_CALLBACK::' + id + "::" + message.ticket, message);
    }else if(message.type === 'buffer') {
        var callback = this.callback(id, message.ticket);
Severity: Minor
Found in lib/CommunicationModel.js - About 1 hr to fix

    Function STC_COM_CALLBACK has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    CommunicationModel.prototype.callback = function STC_COM_CALLBACK(id, ticket) {
        var _this = this;
        return function STC_WORKER_CALLBACK(error, extension) {
            if(error) {
                _this.send(id, { ticket: ticket, success: false, error: error.message });
    Severity: Minor
    Found in lib/CommunicationModel.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function STC_COM_SEND has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    CommunicationModel.prototype.send = function STC_COM_SEND(id, message, timeout, callback) {
        // Check if ID is valid
        if((!this.cluster.workers[id]) && (id !== 'master')) {
            if(callback) {
                return callback(new Error('Worker with the given ID was not found.'));
    Severity: Minor
    Found in lib/CommunicationModel.js - About 1 hr to fix

      Function autoBuffer has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      CommunicationModel.prototype.autoBuffer = function STC_AUTO_BUFFER(workerID, name, buffer, encoding, mutable, sendInChunks, callback) {
      Severity: Major
      Found in lib/CommunicationModel.js - About 50 mins to fix

        Function STC_BUFFER has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        CommunicationModel.prototype.buffer = function STC_BUFFER(workerID, BufferProtoObject, buffer, sendInChunks, callback) {
            var _this = this;
            
            // Chucks buffer/Creates MD5 checksum etc.
            BufferProtoObject.setBuffer(buffer);
        Severity: Minor
        Found in lib/CommunicationModel.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function allocate has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        CommunicationModel.prototype.allocate = function STC_COM_ALLOCATE(name, size, encoding, mutable, split) {
        Severity: Minor
        Found in lib/CommunicationModel.js - About 35 mins to fix

          Function buffer has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          CommunicationModel.prototype.buffer = function STC_BUFFER(workerID, BufferProtoObject, buffer, sendInChunks, callback) {
          Severity: Minor
          Found in lib/CommunicationModel.js - About 35 mins to fix

            Expected return with your callback function.
            Open

                            callback(null, { allocated: true });
            Severity: Minor
            Found in lib/CommunicationModel.js by eslint

            Enforce Return After Callback (callback-return)

            The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

            function doSomething(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

            Rule Details

            This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

            Options

            The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

            Default callback names

            Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err);
                }
                callback();
            }

            Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            Supplied callback names

            Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    send.error(err);
                }
                send.success();
            }

            Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    return done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    return send.error(err);
                }
                send.success();
            }

            Known Limitations

            Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

            • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
            • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

            Passing the callback by reference

            The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    setTimeout(callback, 0); // this is bad, but WILL NOT warn
                }
                callback();
            }

            Triggering the callback within a nested function

            The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    process.nextTick(function() {
                        return callback(); // this is bad, but WILL NOT warn
                    });
                }
                callback();
            }

            If/else statements

            The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

            Example of a false positive when this rule reports incorrect code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err); // this is fine, but WILL warn
                } else {
                    callback();    // this is fine, but WILL warn
                }
            }

            When Not To Use It

            There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

            Further Reading

            Related Rules

            Expected return with your callback function.
            Open

                                callback(null, { ticket: "STC_BUFFER:" + message.name, digest: buffer.digest(), encoding: buffer.encoding });
            Severity: Minor
            Found in lib/CommunicationModel.js by eslint

            Enforce Return After Callback (callback-return)

            The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

            function doSomething(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

            Rule Details

            This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

            Options

            The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

            Default callback names

            Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err);
                }
                callback();
            }

            Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            Supplied callback names

            Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    send.error(err);
                }
                send.success();
            }

            Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    return done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    return send.error(err);
                }
                send.success();
            }

            Known Limitations

            Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

            • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
            • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

            Passing the callback by reference

            The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    setTimeout(callback, 0); // this is bad, but WILL NOT warn
                }
                callback();
            }

            Triggering the callback within a nested function

            The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    process.nextTick(function() {
                        return callback(); // this is bad, but WILL NOT warn
                    });
                }
                callback();
            }

            If/else statements

            The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

            Example of a false positive when this rule reports incorrect code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err); // this is fine, but WILL warn
                } else {
                    callback();    // this is fine, but WILL warn
                }
            }

            When Not To Use It

            There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

            Further Reading

            Related Rules

            The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
            Open

                        if(extension) for (var property in extension) { message[property] = extension[property]; }
            Severity: Minor
            Found in lib/CommunicationModel.js by eslint

            Require Guarding for-in (guard-for-in)

            Looping over objects with a for in loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.

            for (key in foo) {
                doSomething(key);
            }

            Note that simply checking foo.hasOwnProperty(key) is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).

            Rule Details

            This rule is aimed at preventing unexpected behavior that could arise from using a for in loop without filtering the results in the loop. As such, it will warn when for in loops do not filter their results with an if statement.

            Examples of incorrect code for this rule:

            /*eslint guard-for-in: "error"*/
            
            for (key in foo) {
                doSomething(key);
            }

            Examples of correct code for this rule:

            /*eslint guard-for-in: "error"*/
            
            for (key in foo) {
                if (Object.prototype.hasOwnProperty.call(foo, key)) {
                    doSomething(key);
                }
                if ({}.hasOwnProperty.call(foo, key)) {
                    doSomething(key);
                }
            }

            Related Rules

            • [no-prototype-builtins](no-prototype-builtins.md)

            Further Reading

            Expected return with your callback function.
            Open

                        if(callback) callback((response.error)?(new Error(response.error)):null, response.success, response);
            Severity: Minor
            Found in lib/CommunicationModel.js by eslint

            Enforce Return After Callback (callback-return)

            The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

            function doSomething(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

            Rule Details

            This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

            Options

            The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

            Default callback names

            Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err);
                }
                callback();
            }

            Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            Supplied callback names

            Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    send.error(err);
                }
                send.success();
            }

            Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    return done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    return send.error(err);
                }
                send.success();
            }

            Known Limitations

            Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

            • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
            • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

            Passing the callback by reference

            The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    setTimeout(callback, 0); // this is bad, but WILL NOT warn
                }
                callback();
            }

            Triggering the callback within a nested function

            The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    process.nextTick(function() {
                        return callback(); // this is bad, but WILL NOT warn
                    });
                }
                callback();
            }

            If/else statements

            The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

            Example of a false positive when this rule reports incorrect code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err); // this is fine, but WILL warn
                } else {
                    callback();    // this is fine, but WILL warn
                }
            }

            When Not To Use It

            There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

            Further Reading

            Related Rules

            TODO found
            Open

                    // TODO
            Severity: Minor
            Found in lib/CommunicationModel.js by fixme

            Move function declaration to function body root.
            Open

                    function STC_SEND_CALLBACK(response) {
            Severity: Minor
            Found in lib/CommunicationModel.js by eslint

            disallow variable or function declarations in nested blocks (no-inner-declarations)

            In JavaScript, prior to ES6, a function declaration is only allowed in the first level of a program or the body of another function, though parsers sometimes erroneously accept them elsewhere. This only applies to function declarations; named or anonymous function expressions can occur anywhere an expression is permitted.

            // Good
            function doSomething() { }
            
            // Bad
            if (test) {
                function doSomethingElse () { }
            }
            
            function anotherThing() {
                var fn;
            
                if (test) {
            
                    // Good
                    fn = function expression() { };
            
                    // Bad
                    function declaration() { }
                }
            }

            A variable declaration is permitted anywhere a statement can go, even nested deeply inside other blocks. This is often undesirable due to variable hoisting, and moving declarations to the root of the program or function body can increase clarity. Note that block bindings (let, const) are not hoisted and therefore they are not affected by this rule.

            /*eslint-env es6*/
            
            // Good
            var foo = 42;
            
            // Good
            if (foo) {
                let bar1;
            }
            
            // Bad
            while (test) {
                var bar2;
            }
            
            function doSomething() {
                // Good
                var baz = true;
            
                // Bad
                if (baz) {
                    var quux;
                }
            }

            Rule Details

            This rule requires that function declarations and, optionally, variable declarations be in the root of a program or the body of a function.

            Options

            This rule has a string option:

            • "functions" (default) disallows function declarations in nested blocks
            • "both" disallows function and var declarations in nested blocks

            functions

            Examples of incorrect code for this rule with the default "functions" option:

            /*eslint no-inner-declarations: "error"*/
            
            if (test) {
                function doSomething() { }
            }
            
            function doSomethingElse() {
                if (test) {
                    function doAnotherThing() { }
                }
            }

            Examples of correct code for this rule with the default "functions" option:

            /*eslint no-inner-declarations: "error"*/
            
            function doSomething() { }
            
            function doSomethingElse() {
                function doAnotherThing() { }
            }
            
            if (test) {
                asyncCall(id, function (err, data) { });
            }
            
            var fn;
            if (test) {
                fn = function fnExpression() { };
            }

            both

            Examples of incorrect code for this rule with the "both" option:

            /*eslint no-inner-declarations: ["error", "both"]*/
            
            if (test) {
                var foo = 42;
            }
            
            function doAnotherThing() {
                if (test) {
                    var bar = 81;
                }
            }

            Examples of correct code for this rule with the "both" option:

            /*eslint no-inner-declarations: "error"*/
            /*eslint-env es6*/
            
            var bar = 42;
            
            if (test) {
                let baz = 43;
            }
            
            function doAnotherThing() {
                var baz = 81;
            }

            When Not To Use It

            The function declaration portion rule will be rendered obsolete when block-scoped functions land in ES6, but until then, it should be left on to enforce valid constructions. Disable checking variable declarations when using [block-scoped-var](block-scoped-var.md) or if declaring variables in nested blocks is acceptable despite hoisting. Source: http://eslint.org/docs/rules/

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if(message.done) {
                                buffer.set(message.data, message.chunk);
                                buffer.setDone();
                                // Finish Buffer
                                callback(null, { ticket: "STC_BUFFER:" + message.name, digest: buffer.digest(), encoding: buffer.encoding });
            Severity: Major
            Found in lib/CommunicationModel.js and 1 other location - About 3 hrs to fix
            lib/Worker.js on lines 83..90

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status