scott-wyatt/trailpack-stripe

View on GitHub
api/models/Applicationfeerefund.js

Summary

Maintainability
F
4 days
Test Coverage

Function schema has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static schema (app, Sequelize) {
    let schema = {}
    if (app.config.database.orm === 'waterline' || app.config.database.orm === 'js-data') {
      schema = {
        id: {
Severity: Major
Found in api/models/Applicationfeerefund.js - About 3 hrs to fix

    Function config has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      static config (app) {
        let config = {}
    
        if (app && (app.config.database.orm === 'waterline' || app.config.database.orm === 'js-data')) {
          config = {
    Severity: Minor
    Found in api/models/Applicationfeerefund.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function config has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static config (app) {
        let config = {}
    
        if (app && (app.config.database.orm === 'waterline' || app.config.database.orm === 'js-data')) {
          config = {
    Severity: Minor
    Found in api/models/Applicationfeerefund.js - About 1 hr to fix

      Function schema has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        static schema (app, Sequelize) {
          let schema = {}
          if (app.config.database.orm === 'waterline' || app.config.database.orm === 'js-data') {
            schema = {
              id: {
      Severity: Minor
      Found in api/models/Applicationfeerefund.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

        static config (app) {
          let config = {}
      
          if (app && (app.config.database.orm === 'waterline' || app.config.database.orm === 'js-data')) {
            config = {
      Severity: Major
      Found in api/models/Applicationfeerefund.js and 7 other locations - About 1 day to fix
      api/models/Bankaccount.js on lines 11..59
      api/models/Bitcoin.js on lines 11..59
      api/models/Card.js on lines 11..59
      api/models/Dispute.js on lines 11..59
      api/models/Recipient.js on lines 11..59
      api/models/Refund.js on lines 11..59
      api/models/Transferreversal.js on lines 11..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 260.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 20 locations. Consider refactoring.
      Open

            if (database.models[this.constructor.name.toLowerCase()]) {
              if (database.stores[database.models[this.constructor.name.toLowerCase()].store].dialect == 'postgres') {
                sJSON = (field) => {
                  return {
                    type: Sequelize.JSON
      Severity: Major
      Found in api/models/Applicationfeerefund.js and 19 other locations - About 6 hrs to fix
      api/models/Applicationfee.js on lines 133..148
      api/models/Bankaccount.js on lines 129..144
      api/models/Bitcoin.js on lines 153..168
      api/models/Card.js on lines 153..168
      api/models/Charge.js on lines 181..196
      api/models/Coupon.js on lines 126..141
      api/models/Customer.js on lines 126..141
      api/models/Discount.js on lines 119..134
      api/models/Event.js on lines 106..121
      api/models/Invoice.js on lines 223..238
      api/models/Invoiceitem.js on lines 140..155
      api/models/Plan.js on lines 123..138
      api/models/Recipient.js on lines 132..147
      api/models/Refund.js on lines 120..135
      api/models/Sku.js on lines 139..154
      api/models/Subscription.js on lines 180..195
      api/models/Token.js on lines 108..123
      api/models/Transfer.js on lines 153..168
      api/models/Transferreversal.js on lines 114..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 164.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if (app.config.database.orm === 'waterline' || app.config.database.orm === 'js-data') {
            schema = {
              id: {
                type: 'string', //"fr_xxxxxxxxx",
                primaryKey: true,
      Severity: Major
      Found in api/models/Applicationfeerefund.js and 2 other locations - About 5 hrs to fix
      api/models/Orderitem.js on lines 57..126
      api/models/Transferreversal.js on lines 63..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 139.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 24 locations. Consider refactoring.
      Open

            let sJSON = (field) =>{
              return {
                type: Sequelize.STRING,
                get: function() {
                  return JSON.parse(this.getDataValue(field))
      Severity: Major
      Found in api/models/Applicationfeerefund.js and 23 other locations - About 2 hrs to fix
      api/models/Applicationfee.js on lines 121..131
      api/models/Bankaccount.js on lines 117..127
      api/models/Bitcoin.js on lines 141..151
      api/models/Card.js on lines 141..151
      api/models/Charge.js on lines 169..179
      api/models/Coupon.js on lines 114..124
      api/models/Customer.js on lines 114..124
      api/models/Discount.js on lines 107..117
      api/models/Dispute.js on lines 126..136
      api/models/Event.js on lines 94..104
      api/models/Invoice.js on lines 211..221
      api/models/Invoiceitem.js on lines 128..138
      api/models/Order.js on lines 143..153
      api/models/Plan.js on lines 111..121
      api/models/Product.js on lines 126..136
      api/models/Recipient.js on lines 120..130
      api/models/Refund.js on lines 108..118
      api/models/Sku.js on lines 127..137
      api/models/Stripeaccount.js on lines 153..163
      api/models/Subscription.js on lines 168..178
      api/models/Token.js on lines 96..106
      api/models/Transfer.js on lines 141..151
      api/models/Transferreversal.js on lines 102..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status