scottwernervt/clipmanager

View on GitHub

Showing 17 of 33 total issues

File mainwindow.py has 458 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
import logging
import zlib

from PySide.QtCore import (
Severity: Minor
Found in clipmanager/ui/mainwindow.py - About 7 hrs to fix

    Settings has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Settings(QObject):
        """Allows other modules to access application settings.
    
        Todo:
            Possibly change to requesting settings by string instead of defining
    Severity: Minor
    Found in clipmanager/settings.py - About 2 hrs to fix

      Function toggle_window has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def toggle_window(self):
              """Show and hide main window.
      
              If visible, then hide the window. If not visible, then open window
              based on position settings at: mouse cursor, system tray, or last
      Severity: Minor
      Found in clipmanager/ui/mainwindow.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def __init__(self, parent=None):
              super(SettingsDialog, self).__init__(parent)
      
              self.settings = Settings()
      
      
      Severity: Major
      Found in clipmanager/ui/dialogs/settings.py - About 2 hrs to fix

        Function unregister has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def unregister(self, sequence=None, callback=None, winid=None):
                if sequence is not None:
                    assert callback is not None, 'Invalid parameter'
                    if isinstance(sequence, str):
                        sequence = QKeySequence(sequence)
        Severity: Minor
        Found in clipmanager/hotkey/base.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def __init__(self, parent=None):
                super(HistoryListView, self).__init__(parent)
        
                self.parent = parent
        
        
        Severity: Minor
        Found in clipmanager/ui/historylist.py - About 1 hr to fix

          Function __init__ has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def __init__(self, parent=None):
                  super(MainWidget, self).__init__(parent)
          
                  self.parent = parent
          
          
          Severity: Minor
          Found in clipmanager/ui/mainwindow.py - About 1 hr to fix

            Function __init__ has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def __init__(self, parent=None):
                    super(SystemTrayIcon, self).__init__(parent)
            
                    self.parent = parent
            
            
            Severity: Minor
            Found in clipmanager/ui/systemtray.py - About 1 hr to fix

              Function keyPressEvent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def keyPressEvent(self, event):
                      """Capture key and modifier presses and insert then.
              
                      References:
                      http://stackoverflow.com/questions/6647970/how-can-i-capture-qkey_sequence-from-qkeyevent-depending-on-current-keyboard-layo
              Severity: Minor
              Found in clipmanager/ui/dialogs/settings.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function new_item has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def new_item(self, mime_data):
                      """Append clipboard contents to database.
              
                      :param mime_data: Clipboard contents mime data
                      :type mime_data: QMimeData
              Severity: Minor
              Found in clipmanager/ui/mainwindow.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __init__ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def __init__(self, mime_data, parent=None):
                      """Preview display is determined by mime format.
              
                      :param mime_data:
                      :type mime_data: QMimeData
              Severity: Minor
              Found in clipmanager/ui/dialogs/preview.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __init__ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def __init__(self):
                      self.last_error = False
                      self.pid_path = os.path.normpath(
                          os.path.join(
                              tempfile.gettempdir(),
              Severity: Minor
              Found in clipmanager/singleinstance.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_win32_owner has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def get_win32_owner():
                  """Get clipboard owner window details.
              
                  Sources:
                  https://sjohannes.wordpress.com/2012/03/23/win32-python-getting-all-window-titles/
              Severity: Minor
              Found in clipmanager/owner/win32.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                          return None
              Severity: Major
              Found in clipmanager/ui/mainwindow.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return None
                Severity: Major
                Found in clipmanager/models.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return True
                  Severity: Major
                  Found in clipmanager/ui/mainwindow.py - About 30 mins to fix

                    Function keyPressEvent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def keyPressEvent(self, event):
                            """Allow arrow selection on history list from search box.
                    
                            Override QLineEdit.keyPressEvent and check for up and down arrow key
                            for changing selection. If conditional checks not met, return original
                    Severity: Minor
                    Found in clipmanager/ui/searchedit.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language