scottwillson/racing_on_rails

View on GitHub
app/assets/javascripts/select_modal.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function bindSelectModal has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function bindSelectModal() {
  jQuery('button.select-modal').each(function(index, element) {
    var button = jQuery(element);
    var method = button.data('method');
    var objectName = button.data('object-name');
Severity: Major
Found in app/assets/javascripts/select_modal.js - About 2 hrs to fix

    Function searchFor has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function searchFor(type, objectName, method, selectText) {
      if (!jQuery('#' + objectName + '_' + method + '_select_modal').is(':visible')) {
        return;
      }
    
    
    Severity: Minor
    Found in app/assets/javascripts/select_modal.js - About 1 hr to fix

      Unnecessary semicolon.
      Open

      };

      disallow unnecessary semicolons (no-extra-semi)

      Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

      Rule Details

      This rule disallows unnecessary semicolons.

      Examples of incorrect code for this rule:

      /*eslint no-extra-semi: "error"*/
      
      var x = 5;;
      
      function foo() {
          // code
      };

      Examples of correct code for this rule:

      /*eslint no-extra-semi: "error"*/
      
      var x = 5;
      
      var foo = function() {
          // code
      };

      When Not To Use It

      If you intentionally use extra semicolons then you can disable this rule.

      Related Rules

      'Promise' is not defined.
      Open

          return Promise.resolve(false);

      Disallow Undeclared Variables (no-undef)

      This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

      Rule Details

      Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

      Examples of incorrect code for this rule:

      /*eslint no-undef: "error"*/
      
      var a = someFunction();
      b = 10;

      Examples of correct code for this rule with global declaration:

      /*global someFunction b:true*/
      /*eslint no-undef: "error"*/
      
      var a = someFunction();
      b = 10;

      The b:true syntax in /*global */ indicates that assignment to b is correct.

      Examples of incorrect code for this rule with global declaration:

      /*global b*/
      /*eslint no-undef: "error"*/
      
      b = 10;

      By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

      Options

      • typeof set to true will warn for variables used inside typeof check (Default false).

      typeof

      Examples of correct code for the default { "typeof": false } option:

      /*eslint no-undef: "error"*/
      
      if (typeof UndefinedIdentifier === "undefined") {
          // do something ...
      }

      You can use this option if you want to prevent typeof check on a variable which has not been declared.

      Examples of incorrect code for the { "typeof": true } option:

      /*eslint no-undef: ["error", { "typeof": true }] */
      
      if(typeof a === "string"){}

      Examples of correct code for the { "typeof": true } option with global declaration:

      /*global a*/
      /*eslint no-undef: ["error", { "typeof": true }] */
      
      if(typeof a === "string"){}

      Environments

      For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

      browser

      Examples of correct code for this rule with browser environment:

      /*eslint no-undef: "error"*/
      /*eslint-env browser*/
      
      setTimeout(function() {
          alert("Hello");
      });

      node

      Examples of correct code for this rule with node environment:

      /*eslint no-undef: "error"*/
      /*eslint-env node*/
      
      var fs = require("fs");
      module.exports = function() {
          console.log(fs);
      };

      When Not To Use It

      If explicit declaration of global variables is not to your taste.

      Compatibility

      This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status