Method to_excel has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

  def to_excel(value)
    case value
    when TrueClass
      "1"
    when FalseClass

• Read up
  Read up

Method _stable_merge has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

  def _stable_merge(left, right, &predicate)
    sorted = []
    until left.empty? || right.empty?
      sorted << if predicate
                  if yield(right.first, left.first)

• Read up
  Read up

Method test_compare_by_most_recent_result has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def test_compare_by_most_recent_result
        x = Struct::CalculatorResult.new
        y = Struct::CalculatorResult.new
        assert_equal 0, Calculator.compare_by_most_recent_result(x, y)

Method category_names has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def category_names
      [
        "Category 3 Men",
        "Category 3 Women",
        "Category 4/5 Men",

Method merge has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def merge(team)
      raise(ArgumentError, "Cannot merge nil team") unless team
      return false if team == self

      Team.transaction do

Method test_by_time has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        def test_by_time
          category = Models::Category.new("Masters Men")
          rules = Rules.new(category_rules: [Models::CategoryRule.new(category)], place_by: "time")
          calculator = Calculator.new(rules: rules, source_results: [])
          event_category = calculator.event_categories.first

Method calculate! has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def self.calculate!(year = Time.zone.today.year)
      ActiveSupport::Notifications.instrument "calculate.#{name}.competitions.racing_on_rails" do
        transaction do
          year = year.to_i if year.is_a?(String)
          date = Date.new(year, 1, 1)

Method index has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def index
    @calendar_tab = "Calendar"

    respond_to do |format|
      format.html do

Method calculate! has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def calculate!(source_calculations: true)
    ActiveSupport::Notifications.instrument "calculate.calculations.#{name}.racing_on_rails" do
      clear_cache
      clear_source_results_cache
      calculate_source_calculations if source_calculations

Method unique_number has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def unique_number
    _discipline = Discipline.find(discipline_id)
    if number_issuer.association? && RaceNumber.rental?(value, _discipline)
      errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")
      person.errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")

Method test_junior has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def test_junior
      category = Stub.new
      assert !category.junior?, "No ages junior?"

      category = Stub.new

Method test_minimum_events_before_event_complete has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def test_minimum_events_before_event_complete
        source_results = [
          result(id: 1, event_id: 1, race_id: 1, participant_id: 1, place: "1"),
          result(id: 2, event_id: 2, race_id: 2, participant_id: 1, place: "6"),
          result(id: 3, event_id: 2, race_id: 2, participant_id: 2, place: "2"),

Method test_weekly_series_calculated_overall has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        def test_weekly_series_calculated_overall
          category = Models::Category.new("Women")
          rules = Rules.new(
            category_rules: [Models::CategoryRule.new(category)],
            weekday_events: false

Method import has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def import
        case params[:commit]
        when "Cancel"
          session[:people_file_path] = nil
          redirect_to(action: "index")

Method update has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def update
      @category = Category.find(params[:id])
      @category.assign_attributes category_params

      if @category.name_changed?

Consider simplifying this complex logical expression.

Open

      if candidate_categories.one? { |category| category.ability_begin == highest_ability && category.gender == gender && (!category.junior? || category.ages.size <= ages.size) }
        highest_ability_category = candidate_categories.detect { |category| category.ability_begin == highest_ability && category.gender == gender && (!category.junior? || category.ages.size <= ages.size) }
        debug "highest ability for gender: #{highest_ability_category.name}"
        return highest_ability_category if highest_ability_category.include?(self)
      end

Consider simplifying this complex logical expression.

Open

    unless administrator? ||
           (@event && (current_person == @event.promoter || @event.editors.include?(current_person))) ||
           (@race && (current_person == @race.event.promoter || @race.event.editors.include?(current_person)))

      redirect_to unauthorized_path

Method unique_number has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

  def unique_number
    _discipline = Discipline.find(discipline_id)
    if number_issuer.association? && RaceNumber.rental?(value, _discipline)
      errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")
      person.errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")

• Read up
  Read up

Method destroy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

  def self.destroy(post)
    transaction do
      original = find_original(post)
      if original
        original.replies_count = original.replies_count - 1

• Read up
  Read up

Method valid_dates has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    def valid_dates
      if all_year?
        errors.add "start_date", "must be January 1st, but was: '#{start_date}'" if start_date.nil? || start_date != start_date.beginning_of_year
        errors.add "end_date", "must be December 31st, but was: '#{end_date}'" if end_date.nil? || end_date != end_date.end_of_year
      end

• Read up
  Read up