scrum2b/scrum2b

View on GitHub
assets/javascripts/validate.js

Summary

Maintainability
F
4 days
Test Coverage

File validate.js has 929 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * jQuery Validation Plugin 1.9.0
 *
 * http://bassistance.de/jquery-plugins/jquery-plugin-validation/
 * http://docs.jquery.com/Plugins/Validation
Severity: Major
Found in assets/javascripts/validate.js - About 2 days to fix

    Function validate has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        validate : function(options) {
    
          // if nothing is selected, return nothing; can't chain anyway
          if (!this.length) {
            options && options.debug && window.console && console.warn("nothing selected, can't validate, returning nothing");
    Severity: Major
    Found in assets/javascripts/validate.js - About 2 hrs to fix

      Function normalizeRules has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          normalizeRules : function(rules, element) {
            // handle dependency check
            $.each(rules, function(prop, val) {
              // ignore rule when param is explicitly false, eg. required:false
              if (val === false) {
      Severity: Major
      Found in assets/javascripts/validate.js - About 2 hrs to fix

        Function remote has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              remote : function(value, element, param) {
                if (this.optional(element))
                  return "dependency-mismatch";
        
                var previous = this.previousValue(element);
        Severity: Minor
        Found in assets/javascripts/validate.js - About 1 hr to fix

          Function rules has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              rules : function(command, argument) {
                var element = this[0];
          
                if (command) {
                  var settings = $.data(element.form, 'validator').settings;
          Severity: Minor
          Found in assets/javascripts/validate.js - About 1 hr to fix

            Function check has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  check : function(element) {
                    element = this.validationTargetFor(this.clean(element));
            
                    var rules = $(element).rules();
                    var dependencyMismatch = false;
            Severity: Minor
            Found in assets/javascripts/validate.js - About 1 hr to fix

              Function init has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    init : function() {
                      this.labelContainer = $(this.settings.errorLabelContainer);
                      this.errorContext = this.labelContainer.length && this.labelContainer || $(this.currentForm);
                      this.containers = $(this.settings.errorContainer).add(this.settings.errorLabelContainer);
                      this.submitted = {};
              Severity: Minor
              Found in assets/javascripts/validate.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      unhighlight : function(element, errorClass, validClass) {
                        if (element.type === 'radio') {
                          this.findByName(element.name).removeClass(errorClass).addClass(validClass);
                        } else {
                          $(element).removeClass(errorClass).addClass(validClass);
                Severity: Major
                Found in assets/javascripts/validate.js and 1 other location - About 2 hrs to fix
                assets/javascripts/validate.js on lines 244..250

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 86.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      highlight : function(element, errorClass, validClass) {
                        if (element.type === 'radio') {
                          this.findByName(element.name).addClass(errorClass).removeClass(validClass);
                        } else {
                          $(element).addClass(errorClass).removeClass(validClass);
                Severity: Major
                Found in assets/javascripts/validate.js and 1 other location - About 2 hrs to fix
                assets/javascripts/validate.js on lines 251..257

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 86.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      maxlength : function(value, element, param) {
                        return this.optional(element) || this.getLength($.trim(value), element) <= param;
                      },
                Severity: Minor
                Found in assets/javascripts/validate.js and 1 other location - About 50 mins to fix
                assets/javascripts/validate.js on lines 984..986

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      minlength : function(value, element, param) {
                        return this.optional(element) || this.getLength($.trim(value), element) >= param;
                      },
                Severity: Minor
                Found in assets/javascripts/validate.js and 1 other location - About 50 mins to fix
                assets/javascripts/validate.js on lines 989..991

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status