Sign upLogin

sds/haml-lint

View on GitHub
Star

Showing 58 of 58 total issues

Method process_source has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def process_source(source) # rubocop:disable Metrics/MethodLength
      @source = process_encoding(source)
      @source = strip_frontmatter(source)
      # the -1 is to keep the empty strings at the end of the array when the source
      # ended with multiple new-lines
Severity: Minor
Found in lib/haml_lint/document.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visit_tag has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def visit_tag(node)
      return unless node.tag_name == 'div'

      return unless node.static_classes.any? || node.static_ids.any?
Severity: Minor
Found in lib/haml_lint/linter/implicit_div.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method next_node has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def next_node(node)
      return unless node
      siblings = node.parent ? node.parent.children : [node]

      next_sibling = siblings[siblings.index(node) + 1] if siblings.count > 1
Severity: Minor
Found in lib/haml_lint/linter.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visit_root has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def visit_root(_node) # rubocop:disable Metrics
      # Need to call the received block to avoid Linter automatically visiting children
      # Only important thing is that the argument is not ":children"
      yield :skip_children
Severity: Minor
Found in lib/haml_lint/linter/rubocop.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visit_root has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def visit_root(root)
      document.source_lines.each_with_index do |line, index|
        next unless /\s+$/.match?(line)

        node = root.node_for_line(index + 1)
Severity: Minor
Found in lib/haml_lint/linter/trailing_whitespace.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visit_filter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def visit_filter(node)
      # For unknown reasons, haml doesn't escape interpolations in filters.
      # So we can rely on \n to split / get the number of lines.
      filter_name_indent = @original_haml_lines[node.line - 1].index(/\S/)
      if node.filter_type == 'ruby'
Severity: Minor
Found in lib/haml_lint/ruby_extraction/chunk_extractor.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method gem_config_path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def gem_config_path(gem_name, relative_config_path)
        if defined?(Bundler)
          gem = Bundler.load.specs[gem_name].first
          gem_path = gem.full_gem_path if gem
        end
Severity: Minor
Found in lib/haml_lint/configuration_loader.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visit_root has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def visit_root(root)
      return if document.source.empty?
      line_number = document.last_non_empty_line

      node = root.node_for_line(line_number)
Severity: Minor
Found in lib/haml_lint/linter/final_newline.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return unless tag_with_text[index - 1] != ' '
Severity: Major
Found in lib/haml_lint/linter/space_before_script.rb - About 30 mins to fix

    Method pick_a_script_output_prefix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def pick_a_script_output_prefix
      if @document.source.match?(/\bHL\.out\b/)
        100.times do
          suffix = SecureRandom.hex(10)
          next if @document.source.include?(suffix)
    Severity: Minor
    Found in lib/haml_lint/ruby_extraction/coordinator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visit_root has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def visit_root(root)
      max_length = config['max']

      document.source_lines.each_with_index do |line, index|
        next if line.length <= max_length
    Severity: Minor
    Found in lib/haml_lint/linter/line_length.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visit_tag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def visit_tag(node)
      # Convert ".class#id" into [.class, #id] (preserving order)
      components = node.static_attributes_source.scan(/[.#][^.#]+/)

      first, second = attribute_prefix_order
    Severity: Minor
    Found in lib/haml_lint/linter/classes_before_ids.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load_from_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def load_from_file(file) # rubocop:disable Metrics
        content = File.read(file)

        processed_content = HamlLint::Utils.process_erb(content)
        hash = (YAML.safe_load(processed_content) || {}).to_hash
    Severity: Minor
    Found in lib/haml_lint/configuration_loader.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def each
      return to_enum(__callee__) unless block_given?

      node = self
      loop do
    Severity: Minor
    Found in lib/haml_lint/tree/node.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method line_numbers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def line_numbers
      return (line..line) unless @value && text

      end_line = if !lines.empty?
                   line + lines.count - 1
    Severity: Minor
    Found in lib/haml_lint/tree/node.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pick_a_marker_prefix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def pick_a_marker_prefix
      if @document.source.match?(/\bhaml_lint_/)
        100.times do
          suffix = SecureRandom.hex(10)
          next if @document.source.include?(suffix)
    Severity: Minor
    Found in lib/haml_lint/ruby_extraction/coordinator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def run(document, autocorrect: nil) # rubocop:disable Metrics
      run_or_raise(document, autocorrect: autocorrect)
    rescue Parser::SyntaxError => e
      location = e.diagnostic.location
      @lints <<
    Severity: Minor
    Found in lib/haml_lint/linter.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def load_file(file, context = {}) # rubocop:disable Metrics
        context[:loaded_files] ||= []
        context[:loaded_files].map! { |config_file| File.expand_path(config_file) }
        context[:exclude_files] ||= []
        context[:exclude_files].map! { |config_file| File.expand_path(config_file) }
    Severity: Minor
    Found in lib/haml_lint/configuration_loader.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language