Sorry, data for that comparison is no longer available.
Sign upLogin

seatplus/eveapi

View on GitHub
Star
src/Models/Contracts/Contract.php

Summary

Maintainability
A
0 mins
Test Coverage
B
89%

The class Contract has 11 public methods. Consider refactoring Contract to keep number of public methods under 10.
Wontfix

class Contract extends Model implements LocationWatchListInterface, TypeWatchListInterface
{
    use HasFactory;

    protected $guarded = [];
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

TODO found
Confirmed

        return $query // TODO merge tables like assets for improved db performance
Severity: Minor
Found in src/Models/Contracts/Contract.php by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    public function scopeFilterByRegionIds(Builder $query, int|array $regions): Builder
    {
        $region_ids = is_array($regions) ? $regions : [$regions];

        return $query // TODO merge tables like assets for improved db performance
Severity: Major
Found in src/Models/Contracts/Contract.php and 1 other location - About 1 hr to fix
src/Models/Contracts/Contract.php on lines 119..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    public function scopeFilterBySystemIds(Builder $query, int|array $systems): Builder
    {
        $system_ids = is_array($systems) ? $systems : [$systems];

        return $query
Severity: Major
Found in src/Models/Contracts/Contract.php and 1 other location - About 1 hr to fix
src/Models/Contracts/Contract.php on lines 110..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The method start_location is not named in camelCase.
Wontfix

    public function start_location(): HasOne
    {
        return $this->hasOne(Location::class, 'location_id', 'start_location_id');
    }
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method end_location is not named in camelCase.
Wontfix

    public function end_location(): HasOne
    {
        return $this->hasOne(Location::class, 'location_id', 'end_location_id');
    }
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method assignee_corporation is not named in camelCase.
Wontfix

    public function assignee_corporation(): BelongsTo
    {
        return $this->belongsTo(CorporationInfo::class, 'assignee_id', 'corporation_id');
    }
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method issuer_corporation is not named in camelCase.
Wontfix

    public function issuer_corporation(): BelongsTo
    {
        return $this->belongsTo(CorporationInfo::class, 'issuer_corporation_id', 'corporation_id');
    }
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method assignee_character is not named in camelCase.
Wontfix

    public function assignee_character(): BelongsTo
    {
        return $this->belongsTo(CharacterInfo::class, 'assignee_id', 'character_id');
    }
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method issuer_character is not named in camelCase.
Wontfix

    public function issuer_character(): BelongsTo
    {
        return $this->belongsTo(CharacterInfo::class, 'issuer_id', 'character_id');
    }
Severity: Minor
Found in src/Models/Contracts/Contract.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status