seatplus/eveapi

View on GitHub
src/Services/ResolveLocation/Finders/ThroughCorporationMemberTrackingFinder.php

Summary

Maintainability
A
0 mins
Test Coverage
A
94%

Method handle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function handle(int $location_id, Collection $tracking): ?RefreshToken
    {
        $character_ids_to_ignore = $tracking->pluck('character_id');

        $corporation_member_tracking_query = CorporationMemberTracking::query()

    Avoid too many return statements within this method.
    Invalid

            return $refresh_token;

      Avoid excessively long variable names like $corporation_member_tracking_query. Keep variable name length under 20.
      Wontfix

              $corporation_member_tracking_query = CorporationMemberTracking::query()

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
          protected $reallyLongIntName = -3; // VIOLATION - Field
          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
              $otherReallyLongName = -5; // VIOLATION - Local
              for ($interestingIntIndex = 0; // VIOLATION - For
                   $interestingIntIndex < 10;
                   $interestingIntIndex++ ) {
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $character_ids_to_ignore. Keep variable name length under 20.
      Wontfix

              $character_ids_to_ignore = $tracking->pluck('character_id');

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
          protected $reallyLongIntName = -3; // VIOLATION - Field
          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
              $otherReallyLongName = -5; // VIOLATION - Local
              for ($interestingIntIndex = 0; // VIOLATION - For
                   $interestingIntIndex < 10;
                   $interestingIntIndex++ ) {
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status