src/Services/ResolveLocation/Finders/ThroughRandomRefreshTokenFinder.php
Avoid unused parameters such as '$location_id'. Wontfix
Wontfix
public function handle(int $location_id, Collection $tracings): ?RefreshToken- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid excessively long variable names like $character_ids_to_ignore. Keep variable name length under 20. Wontfix
Wontfix
$character_ids_to_ignore = $tracings->pluck('character_id');- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}