Sign upLogin

sebastian-software/core

View on GitHub
Star
source/class/core/bom/ScrollInto.js

Summary

Maintainability
F
4 days
Test Coverage

Function scrollX has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  scrollX : function(element, align)
  {
    var parent = element.parentNode;
    var doc = element.ownerDocument;
    var body = doc.body;
Severity: Major
Found in source/class/core/bom/ScrollInto.js - About 2 hrs to fix

    Function scrollY has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      scrollY : function(element, align)
  {
    var parent = element.parentNode;
    var doc = element.ownerDocument;
    var body = doc.body;
    Severity: Major
    Found in source/class/core/bom/ScrollInto.js - About 2 hrs to fix

      Function scrollX has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        scrollX : function(element, align)
  {
    var parent = element.parentNode;
    var doc = element.ownerDocument;
    var body = doc.body;
      Severity: Minor
      Found in source/class/core/bom/ScrollInto.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function scrollY has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        scrollY : function(element, align)
  {
    var parent = element.parentNode;
    var doc = element.ownerDocument;
    var body = doc.body;
      Severity: Minor
      Found in source/class/core/bom/ScrollInto.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (parent === body)
        {
          parentTop = parent.scrollTop;
          parentOuterHeight = core.bom.Viewport.getHeight();
          parentBottom = parentTop + parentOuterHeight;
      Severity: Major
      Found in source/class/core/bom/ScrollInto.js and 1 other location - About 1 day to fix
      source/class/core/bom/ScrollInto.js on lines 47..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 254.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (parent === body)
        {
          parentLeft = parent.scrollLeft;
          parentOuterWidth = core.bom.Viewport.getWidth();
          parentRight = parentLeft + parentOuterWidth;
      Severity: Major
      Found in source/class/core/bom/ScrollInto.js and 1 other location - About 1 day to fix
      source/class/core/bom/ScrollInto.js on lines 139..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 254.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (parent.scrollWidth > parent.clientWidth && (parent === body || core.bom.Style.get(parent, "overflowX", true) != "visible"))
      {
        // Calculate parent data
        // Special handling for body element
        if (parent === body)
      Severity: Minor
      Found in source/class/core/bom/ScrollInto.js and 1 other location - About 40 mins to fix
      source/class/core/bom/ScrollInto.js on lines 135..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (parent.scrollHeight > parent.clientHeight && (parent === body || core.bom.Style.get(parent, "overflowY", true) != "visible"))
      {
        // Calculate parent data
        // Special handling for body element
        if (parent === body)
      Severity: Minor
      Found in source/class/core/bom/ScrollInto.js and 1 other location - About 40 mins to fix
      source/class/core/bom/ScrollInto.js on lines 43..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status