Sign upLogin

sebastian-software/core

View on GitHub
Star
source/class/core/event/Promise.js

Summary

Maintainability
C
1 day
Test Coverage

File Promise.js has 299 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
==================================================================================================
  Core - JavaScript Foundation
  Copyright 2013-2014 Sebastian Fastner
==================================================================================================
Severity: Minor
Found in source/class/core/event/Promise.js - About 3 hrs to fix

    Function Promise has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function Promise(executor, context) {
        if (typeof executor != "function") {
            throw TypeError("Not a function");
        }
    Severity: Major
    Found in source/class/core/event/Promise.js - About 2 hrs to fix

      Function Queue has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          scheduling_queue = (function Queue() {
        var first, last, item;

        function Item(fn,self) {
            this.fn = fn;
      Severity: Minor
      Found in source/class/core/event/Promise.js - About 1 hr to fix

        Function notifyIsolated has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function notifyIsolated(self,cb,chain) {
        var ret, _then;
        try {
            if (cb === false) {
                chain.reject(self.msg);
        Severity: Minor
        Found in source/class/core/event/Promise.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  return new Constructor(function executor(resolve,reject){
            if (typeof resolve != "function" || typeof reject != "function") {
                throw TypeError("Not a function");
            }
          Severity: Minor
          Found in source/class/core/event/Promise.js and 1 other location - About 40 mins to fix
          source/class/core/event/Promise.js on lines 338..344

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  return new this(function executor(resolve,reject){
            if (typeof resolve != "function" || typeof reject != "function") {
                throw TypeError("Not a function");
            }
          Severity: Minor
          Found in source/class/core/event/Promise.js and 1 other location - About 40 mins to fix
          source/class/core/event/Promise.js on lines 328..334

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status