Sign upLogin

sebastian-software/core

View on GitHub
Star
source/class/core/io/Asset.js

Summary

Maintainability
D
2 days
Test Coverage

File Asset.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
==================================================================================================
    Core - JavaScript Foundation
    Copyright 2010-2012 Zynga Inc.
    Copyright 2012-2014 Sebastian Werner
Severity: Minor
Found in source/class/core/io/Asset.js - About 3 hrs to fix

    Function getFrame has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            getFrame : function(id, frame)
        {
            if (jasy.Env.isSet("debug"))
            {
                core.Assert.isType(id, "String", "Invalid asset ID (no string): " + id + "!");
    Severity: Major
    Found in source/class/core/io/Asset.js - About 3 hrs to fix

      Function preloadSection has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              preloadSection: function(section, recursive, callback, context, random)
        {
            if (jasy.Env.isSet("debug"))
            {
                core.Assert.isType(section, "String");
      Severity: Major
      Found in source/class/core/io/Asset.js - About 2 hrs to fix

        Function getImage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                getImage : function(id)
        {
            if (jasy.Env.isSet("debug")) {
                core.Assert.isType(id, "String", "Invalid asset ID (no string): " + id + "!");
            }
        Severity: Minor
        Found in source/class/core/io/Asset.js - About 1 hr to fix

          Function preloadSection has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  preloadSection: function(section, recursive, callback, context, random)
          Severity: Minor
          Found in source/class/core/io/Asset.js - About 35 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (jasy.Env.isSet("debug"))
            {
                if (!entry) {
                    throw new Error("Could not figure out frame number of unknown image: " + id);
                }
            Severity: Major
            Found in source/class/core/io/Asset.js and 2 other locations - About 1 hr to fix
            source/class/core/io/Asset.js on lines 315..324
            source/class/core/io/Asset.js on lines 372..381

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (jasy.Env.isSet("debug"))
            {
                if (!entry) {
                    throw new Error("Unknown image: " + id);
                }
            Severity: Major
            Found in source/class/core/io/Asset.js and 2 other locations - About 1 hr to fix
            source/class/core/io/Asset.js on lines 288..297
            source/class/core/io/Asset.js on lines 315..324

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (jasy.Env.isSet("debug"))
            {
                if (!entry) {
                    throw new Error("Unknown image: " + id);
                }
            Severity: Major
            Found in source/class/core/io/Asset.js and 2 other locations - About 1 hr to fix
            source/class/core/io/Asset.js on lines 288..297
            source/class/core/io/Asset.js on lines 372..381

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status