Sign upLogin

sebastian-software/core

View on GitHub
Star
source/class/core/property/Debug.js

Summary

Maintainability
C
1 day
Test Coverage

Function checkSetter has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    checkSetter : function(obj, config, args)
    {
        var name = config.name;

        if (args.length == 0) {
Severity: Minor
Found in source/class/core/property/Debug.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkSetter has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    checkSetter : function(obj, config, args)
    {
        var name = config.name;

        if (args.length == 0) {
Severity: Minor
Found in source/class/core/property/Debug.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if (!(value instanceof type || core.Class.includesClass(value.constructor, type))) {
                            throw new Error("Value of property " + name + " must be instance of or include " + type + ". Invalid value: " + value);
                        }
    Severity: Major
    Found in source/class/core/property/Debug.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          else if (core.Interface.isInterface(type))
                    {
                        core.Interface.assert(value, type);
                    }
                    else
      Severity: Major
      Found in source/class/core/property/Debug.js - About 45 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            checkIsValid : function(obj, config, args)
    {
        if (args.length != 0) {
            throw new Error("Called isValid method of property " + config.name + " on " + obj + " with too many arguments!");
        }
        Severity: Major
        Found in source/class/core/property/Debug.js and 2 other locations - About 1 hr to fix
        source/class/core/property/Debug.js on lines 99..104
        source/class/core/property/Debug.js on lines 114..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            checkResetter : function(obj, config, args)
    {
        if (args.length != 0) {
            throw new Error("Called reset method of property " + config.name + " on " + obj + " with too many arguments!");
        }
        Severity: Major
        Found in source/class/core/property/Debug.js and 2 other locations - About 1 hr to fix
        source/class/core/property/Debug.js on lines 114..119
        source/class/core/property/Debug.js on lines 129..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            checkGetter : function(obj, config, args)
    {
        if (args.length != 0) {
            throw new Error("Called get method of property " + config.name + " on " + obj + " with too many arguments!");
        }
        Severity: Major
        Found in source/class/core/property/Debug.js and 2 other locations - About 1 hr to fix
        source/class/core/property/Debug.js on lines 99..104
        source/class/core/property/Debug.js on lines 129..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status