Sign upLogin

sebastian-software/core

View on GitHub
Star
source/class/core/property/Simple.js

Summary

Maintainability
D
1 day
Test Coverage

Function create has 194 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        create : function(config)
        {
            /*
            ---------------------------------------------------------------------------
                INTRO
Severity: Major
Found in source/class/core/property/Simple.js - About 7 hrs to fix

    Function set has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                members.set = function(value)
            {
                var context=this, data, old;

                // Wrap plain types to match property type
    Severity: Minor
    Found in source/class/core/property/Simple.js - About 1 hr to fix

      Function reset has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  members.reset = function()
            {
                var context, data, old, value;
                context = this;
      Severity: Minor
      Found in source/class/core/property/Simple.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (propertyFire)
                    {
                        var eventObject = core.property.Event.obtain(propertyFire, value, old, propertyName);
                        context.dispatchEvent(eventObject);
                        eventObject.release();
        Severity: Minor
        Found in source/class/core/property/Simple.js and 1 other location - About 55 mins to fix
        source/class/core/property/Simple.js on lines 249..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (propertyFire)
                    {
                        var eventObject = core.property.Event.obtain(propertyFire, value, old, propertyName);
                        context.dispatchEvent(eventObject);
                        eventObject.release();
        Severity: Minor
        Found in source/class/core/property/Simple.js and 1 other location - About 55 mins to fix
        source/class/core/property/Simple.js on lines 304..309

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (propertyInit !== undef) {
                        value = propertyInit;
                    }
                    else if (jasy.Env.isSet("debug"))
                    {
        Severity: Minor
        Found in source/class/core/property/Simple.js and 1 other location - About 45 mins to fix
        source/class/core/property/Multi.js on lines 396..405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status