Sign upLogin

sebastian-software/core

View on GitHub
Star
source/class/core/view/Dom.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function loadStyleSheet has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    loadStyleSheet : function(assetId)
    {
      return new core.event.Promise(function(resolve, reject) {
        core.io.StyleSheet.load(jasy.Asset.toUri(assetId), function(uri, errornous, data)
        {
Severity: Minor
Found in source/class/core/view/Dom.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadPartial has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    loadPartial : function(assetId, nostrip)
    {
      return new core.event.Promise(function(resolve, reject) {

        // Auto extract partial name from file name
Severity: Minor
Found in source/class/core/view/Dom.js - About 1 hr to fix

    Function loadTemplate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        loadTemplate : function(assetId, nostrip)
    {
      return new core.event.Promise(function(resolve, reject) {

        // Use cached template if available
    Severity: Minor
    Found in source/class/core/view/Dom.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          show : function(approach)
    {
      var elem = this.getRoot();
      if (!elem) {
        return;
      Severity: Major
      Found in source/class/core/view/Dom.js and 1 other location - About 1 hr to fix
      source/class/core/view/Dom.js on lines 179..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          hide : function(approach)
    {
      var elem = this.getRoot();
      if (!elem) {
        return;
      Severity: Major
      Found in source/class/core/view/Dom.js and 1 other location - About 1 hr to fix
      source/class/core/view/Dom.js on lines 166..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                if (jasy.Env.isSet("debug"))
          {
            if (errornous) {
              this.error("Failed to load template: " + uri);
            } else {
      Severity: Minor
      Found in source/class/core/view/Dom.js and 2 other locations - About 35 mins to fix
      source/class/core/view/Dom.js on lines 242..249
      source/class/core/view/Dom.js on lines 329..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                if (jasy.Env.isSet("debug"))
          {
            if (errornous) {
              this.error("Failed to load partial: " + uri);
            } else {
      Severity: Minor
      Found in source/class/core/view/Dom.js and 2 other locations - About 35 mins to fix
      source/class/core/view/Dom.js on lines 290..297
      source/class/core/view/Dom.js on lines 329..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                if (jasy.Env.isSet("debug"))
          {
            if (errornous) {
              this.error("Failed to load stylesheet: " + uri);
            } else {
      Severity: Minor
      Found in source/class/core/view/Dom.js and 2 other locations - About 35 mins to fix
      source/class/core/view/Dom.js on lines 242..249
      source/class/core/view/Dom.js on lines 290..297

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status