Sign upLogin

sebinbenjamin/image-res-generator

View on GitHub
Star

Showing 4 of 57 total issues

Function generateForConfig has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateForConfig(imageObj, settings, config) {
  const platformPath = path.join(settings.outputDirectory, config.path);
  return fs.ensureDir(platformPath).then(() => {
    // const sectionName = `Generating ${config.type} files for ${config.platform}`;
    const { definitions } = config;
Severity: Minor
Found in src/core/generator.js - About 1 hr to fix

    Function updatePlatforms has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function updatePlatforms(settings) {
  if (settings.configPath) {
    for (const platform in PLATFORM_DEFS) {
      if (Object.prototype.hasOwnProperty.call(PLATFORM_DEFS, platform)) {
        const iconConfig = PLATFORM_DEFS[platform].definitions[0];
    Severity: Minor
    Found in src/core/platform-manager.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getValidFileName has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function getValidFileName(inputFileName) {
  let fileName = inputFileName.slice(); // * TODO: refactor to immutable
  let result;
  const ext = path.extname(fileName);
    Severity: Minor
    Found in src/core/fs-manager.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function generate(imageObj, settings, gSelectedPlatforms) {
  display.header('Generating files');
  display.info('=================');
  const configs = [];
  // * TO DO: Refactor if possible
    Severity: Minor
    Found in src/core/generator.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language