secrethub/ansible-secrethub

View on GitHub

Showing 2 of 16 total issues

Function _run_command has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def _run_command(self, args, stdin=None):
        """Runs a CLI command.

        :param list(str) args: The arguments of the CLI command (e.g. read /path/to/read)
        :param str stdin: Input to supply on stdin.
Severity: Minor
Found in module_utils/client.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def run(self):
        """ Installs or upgrades the SecretHub CLI when needed.

        Installs the SecretHub CLI when the CLI is not yet installed in the configured path.
        When a different version of the CLI is installed, it is upgraded/downgraded.
Severity: Minor
Found in library/secrethub_cli.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language