Sign upLogin

seeseemelk/MockBukkit

View on GitHub
Star

Showing 14 of 110 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public boolean addCustomEffect(@NotNull PotionEffect effect, boolean overwrite) {
        int index = indexOf(effect.getType());

        if (index == -1) {
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java and 1 other location - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public boolean addCustomEffect(@NotNull PotionEffect effect, boolean overwrite)
    {
        int index = indexOf(effect.getType());
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java and 1 other location - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 64..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj)
    {
        if (this == obj)
        {
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/KnowledgeBookMetaMock.java and 3 other locations - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/EnchantedBookMetaMock.java on lines 40..53
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/FireworkMetaMock.java on lines 39..57
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 41..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public boolean removeCustomEffect(@NotNull PotionEffectType type) {
        Iterator<PotionEffect> iterator = effects.iterator();
        boolean changed = false;
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java and 1 other location - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java on lines 142..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public boolean removeCustomEffect(@NotNull PotionEffectType type)
    {
        Iterator<PotionEffect> iterator = effects.iterator();
        boolean changed = false;
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java and 1 other location - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 108..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj)
    {
        if (this == obj)
        {
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/FireworkMetaMock.java and 3 other locations - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/EnchantedBookMetaMock.java on lines 40..53
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/KnowledgeBookMetaMock.java on lines 44..62
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 41..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj) {
            return true;
        }
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/EnchantedBookMetaMock.java and 3 other locations - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/FireworkMetaMock.java on lines 39..57
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/KnowledgeBookMetaMock.java on lines 44..62
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 41..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj) {
            return true;
        }
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java and 3 other locations - About 1 hr to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/EnchantedBookMetaMock.java on lines 40..53
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/FireworkMetaMock.java on lines 39..57
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/KnowledgeBookMetaMock.java on lines 44..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public ScheduledTask(int id, Plugin plugin, boolean isSync, long scheduledTick, Runnable runnable)
    {
        this.id = id;
        this.plugin = plugin;
        this.isSync = isSync;
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/scheduler/ScheduledTask.java and 1 other location - About 50 mins to fix
src/main/java/be/seeseemelk/mockbukkit/entity/AudioExperience.java on lines 22..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    AudioExperience(Sound sound, SoundCategory category, Location l, float volume, float pitch)
    {
        this.sound = sound;
        this.category = category;
        this.location = l;
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/entity/AudioExperience.java and 1 other location - About 50 mins to fix
src/main/java/be/seeseemelk/mockbukkit/scheduler/ScheduledTask.java on lines 17..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (mock != null)
        {
            JavaPlugin instance = mock.getPluginManager().loadPlugin(plugin, descriptionFile, parameters);
            mock.getPluginManager().enablePlugin(instance);
            return plugin.cast(instance);
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java and 1 other location - About 45 mins to fix
src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java on lines 269..278

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (mock != null)
        {
            JavaPlugin instance = mock.getPluginManager().loadPlugin(plugin, description, parameters);
            mock.getPluginManager().enablePlugin(instance);
            return plugin.cast(instance);
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java and 1 other location - About 45 mins to fix
src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java on lines 184..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private int indexOf(PotionEffectType type)
    {
        for (int i = 0; i < effects.size(); ++i)
        {
            if (effects.get(i).getType().equals(type))
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java and 1 other location - About 40 mins to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 125..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private int indexOf(PotionEffectType type) {
        for (int i = 0; i < effects.size(); ++i) {
            if (effects.get(i).getType().equals(type)) {
                return i;
            }
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java and 1 other location - About 40 mins to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java on lines 162..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language