Sign upLogin

seiyria/c

View on GitHub
Star

Showing 26 of 57 total issues

Function exports has 241 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function() {
  var sankey = {},
    nodeWidth = 24,
    nodePadding = 8,
    size = [1, 1],
Severity: Major
Found in src/extjs/sankeyfunctionality.js - About 1 day to fix

Function gameState has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

var gameState = function($q, notificationService, $filter, UPGRADES, ACHIEVEMENTS, GainCalculator, localStorage, AnimatedFlyTip) {

  var getNewState = function() {
    return {
      upgrades: {},
Severity: Minor
Found in src/js/gamestate.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function gameState has 157 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var gameState = function($q, notificationService, $filter, UPGRADES, ACHIEVEMENTS, GainCalculator, localStorage, AnimatedFlyTip) {

  var getNewState = function() {
    return {
      upgrades: {},
Severity: Major
Found in src/js/gamestate.js - About 6 hrs to fix

Function gameController has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var gameController = function($scope, $window, $interval, $filter, $http, $modal, GameState, ChartConfigs, GameTimer, UpgradeManager, FunctionBuilder, UpgradePath, NgTableParams, ACHIEVEMENTS) {
  $scope.ACHIEVEMENTS = ACHIEVEMENTS;
  $scope._visibleUpgrades = [];
  $scope.groupVisibleHash = {};
  $scope.tabActive = [true, false, false, false];
Severity: Major
Found in src/js/gamecontroller.js - About 5 hrs to fix

Function chartConfigs has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var chartConfigs = function($q, GameState) {
  var defer = $q.defer();

  Highcharts.setOptions({
    global: {
Severity: Major
Found in src/js/chartconfigs.js - About 3 hrs to fix

Function sankey has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var sankey = function(UpgradePath) {
  return {
    restrict: 'E',
    scope: {},
    link: function(scope, element) {
Severity: Major
Found in src/js/sankey.js - About 3 hrs to fix

Function link has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    link: function(scope, element) {

      const constants = {
        OPACITY_LOW: 0.2,
        OPACITY_HIGH: 0.6
Severity: Major
Found in src/js/sankey.js - About 3 hrs to fix

Function computeNodeDepths has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function computeNodeDepths(iterations) {
    var nodesByBreadth = d3.nest()
      .key(function(d) { return d.x; })
      .sortKeys(d3.ascending)
      .entries(nodes)
Severity: Major
Found in src/extjs/sankeyfunctionality.js - About 3 hrs to fix

Function gameController has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

var gameController = function($scope, $window, $interval, $filter, $http, $modal, GameState, ChartConfigs, GameTimer, UpgradeManager, FunctionBuilder, UpgradePath, NgTableParams, ACHIEVEMENTS) {
  $scope.ACHIEVEMENTS = ACHIEVEMENTS;
  $scope._visibleUpgrades = [];
  $scope.groupVisibleHash = {};
  $scope.tabActive = [true, false, false, false];
Severity: Minor
Found in src/js/gamecontroller.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File upgrades.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open


module.exports = {
  Scoreboard: {
    category: 'Visual',
    levels: [{cost: 5, description: 'Visualize your score!'}]
Severity: Minor
Found in src/js/upgrades.js - About 2 hrs to fix

Function upgradeManager has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var upgradeManager = function(GameState, UPGRADES, favico) {

  var hasUpgrade = function(key, level = 0) {
    return GameState.upgrade.has(key, level);
  };
Severity: Major
Found in src/js/upgrademanager.js - About 2 hrs to fix

Function functionBuilder has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var functionBuilder = function(GameState, GainCalculator, $window) {
  return {
    build: function() {

      var upgrade = GameState.upgrade;
Severity: Major
Found in src/js/functionbuilder.js - About 2 hrs to fix

Function build has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    build: function() {

      var upgrade = GameState.upgrade;

      var unitText = `${_.camelCase(GameState.currencySet.get())}s`;
Severity: Major
Found in src/js/functionbuilder.js - About 2 hrs to fix

Function functionBuilder has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

var functionBuilder = function(GameState, GainCalculator, $window) {
  return {
    build: function() {

      var upgrade = GameState.upgrade;
Severity: Minor
Found in src/js/functionbuilder.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function() {
  var sankey = {},
    nodeWidth = 24,
    nodePadding = 8,
    size = [1, 1],
Severity: Minor
Found in src/extjs/sankeyfunctionality.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function visible has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var visible = function() {

    var current = GameState.unit.get();
    var allRet = [];
Severity: Minor
Found in src/js/upgrademanager.js - About 1 hr to fix

Function gameController has 14 arguments (exceeds 4 allowed). Consider refactoring.
Open

var gameController = function($scope, $window, $interval, $filter, $http, $modal, GameState, ChartConfigs, GameTimer, UpgradeManager, FunctionBuilder, UpgradePath, NgTableParams, ACHIEVEMENTS) {
Severity: Major
Found in src/js/gamecontroller.js - About 1 hr to fix

Function _initNodes has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      var _initNodes = function() {
        var node = svg.append('g').selectAll('.node')
            .data(scope.data.nodes)
            .enter()
            .append('g')
Severity: Minor
Found in src/js/sankey.js - About 1 hr to fix

Function load has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var load = function() {
    var state = localStorage.get('game');

    if(!state) { return; }
Severity: Minor
Found in src/js/gamestate.js - About 1 hr to fix

Function upgradePath has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var upgradePath = function($q, GameState, UPGRADES) {
  var defer = $q.defer();

  var structure = {
    nodes: [],
Severity: Minor
Found in src/js/upgradepath.js - About 1 hr to fix
Severity
Category
Status
Source
Language