Sign upLogin

sensu-plugins/sensu-plugins-dhcp

View on GitHub
Star

Showing 5 of 5 total issues

Method run has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    response = dhcp_discover
    if response
      puts response if config[:debug]
Severity: Minor
Found in bin/check-dhcp.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dhcp_discover has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def dhcp_discover
    request = DHCP::Discover.new

    listensock = UDPSocket.new
    sendsock = UDPSocket.new
Severity: Minor
Found in bin/check-dhcp.rb - About 1 hr to fix

    Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    response = dhcp_discover
    if response
      puts response if config[:debug]
    Severity: Minor
    Found in bin/check-dhcp.rb - About 1 hr to fix

      Method dhcp_discover has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def dhcp_discover
    request = DHCP::Discover.new

    listensock = UDPSocket.new
    sendsock = UDPSocket.new
      Severity: Minor
      Found in bin/check-dhcp.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  if offer == config[:ipaddr] # rubocop:disable BlockNesting
              ok "Received DHCP offer of IP address #{offer}"
            else
              critical "Received DHCP offer of IP address #{offer}, expected #{config[:ipaddr]}"
            end
      Severity: Major
      Found in bin/check-dhcp.rb - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language